Reword the download.html page, removing mentions of deprecated LiveCD - #138
Conversation
|
Thanks for your contribution! |
…reactos#138) ReactOS commit reactos/reactos@b2e33f2 removed the separate livecd artifact, merging it with the bootcd. Rename also "bootcd" to "Boot Media", since it's more generic (e.g. the ISO can be flashed onto an USB thumb drive). The text of the download.html is reworded to explain what the "Boot Media" does.
e36f041 to
c18bff6
Compare
…reactos#138) ReactOS commit reactos/reactos@b2e33f2 removed the separate livecd artifact, merging it with the bootcd. Rename also "bootcd" to "Boot Media", since it's more generic (e.g. the ISO can be flashed onto an USB thumb drive). The text of the download.html is reworded to explain what the "Boot Media" does.
c18bff6 to
d481339
Compare
…reactos#138) ReactOS commit reactos/reactos@b2e33f2 removed the separate livecd artifact, merging it with the bootcd. Rename also "bootcd" to "Boot Media", since it's more generic (e.g. the ISO can be flashed onto an USB thumb drive). The text of the download.html is reworded to explain what the "Boot Media" does.
d481339 to
4ac611c
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the download page messaging to remove references to the deprecated separate LiveCD artifact, and reframes the primary download as “Boot Media” with updated explanatory text.
Changes:
- Remove LiveCD-specific download option/handling from the download page.
- Reword the download page copy to explain the combined Boot Media (setup vs live environments).
- Minor punctuation/wording tweaks in the donation modal link text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| static/js/download.js | Removes LiveCD selection logic from the download modal flow. |
| content/download.html | Renames “Boot CD” to “Boot Media” and rewrites explanatory text to match the new artifact layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $(".modalbtn").click(function(e){ | ||
| $("#bootcdModal").modal("toggle"); | ||
| url = bootcd; | ||
| if (e.target.textContent == "LiveCD") { | ||
| url = livecd; | ||
| } | ||
| $('.modal-footer a').attr("href", url) | ||
| }); | ||
| }); |
There was a problem hiding this comment.
@copilot Recheck following the updated PR.
…reactos#138) ReactOS commit reactos/reactos@b2e33f2 removed the separate livecd artifact, merging it with the bootcd. Rename also "bootcd" to "Installation Medium", since it's more generic (e.g. the ISO can be flashed onto an USB thumb drive). The text of the download.html page is reworded to explain what the "Installation Medium" does.
4ac611c to
8c57077
Compare
…reactos#138) ReactOS commit reactos/reactos@b2e33f2 removed the separate livecd artifact, merging it with the bootcd. Rename also "bootcd" to "Installation Medium", since it's more generic (e.g. the ISO can be flashed onto an USB thumb drive). The text of the download.html page is reworded to explain what the "Installation Medium" does.
8c57077 to
1b52f07
Compare
16bc60b to
b4db8da
Compare
c16c751 to
0ab3c68
Compare
binarymaster
left a comment
There was a problem hiding this comment.
It can be described in simpler words here, check these suggestions out.
| <div class="text-center"> | ||
| <a id="bootcd" class="buttons" href="https://sourceforge.net/projects/reactos/files/latest/download"><div class="btn btn-primary">Download Boot CD</div></a> | ||
| <p>Alternatively, you can download <a id="livecd" class="modalbtn" href="https://sourceforge.net/projects/reactos/files/ReactOS/0.4.15/ReactOS-{{< reactos-download-version >}}-x86-live.zip/download">LiveCD</a></p> | ||
| <a id="bootcd" class="modalbtn" href="https://sourceforge.net/projects/reactos/files/latest/download"><div class="btn btn-primary">Download Installation Medium</div></a> |
There was a problem hiding this comment.
| <a id="bootcd" class="modalbtn" href="https://sourceforge.net/projects/reactos/files/latest/download"><div class="btn btn-primary">Download Installation Medium</div></a> | |
| <a id="bootcd" class="modalbtn" href="https://sourceforge.net/projects/reactos/files/latest/download"><div class="btn btn-primary">Download ReactOS {{< reactos-version >}}</div></a> |
There was a problem hiding this comment.
Since "ReactOS " is mentioned just above the button, I choose instead to say "Download Release Image" in the button.
There was a problem hiding this comment.
It would be probably still better on the button, but then the text above it should be modified somehow.
There was a problem hiding this comment.
I would say, this could be changed later after the publication (in a separate PR), since the download page would at least:
- have the download button fixed;
- remove visual mentions of "livecd" vs "bootcd".
There was a problem hiding this comment.
Ah ok, if a follow up PR would be welcome, then fine.
There was a problem hiding this comment.
The download button is our call to action, you're trying to create FOMO with the reader.
There was a problem hiding this comment.
In what sense @cbialorucki ? We mention ROS 0.4.x literally just above in the same big font.
There was a problem hiding this comment.
The version should be on the button and we get rid of the redundant text just above the button. Simple.
0ab3c68 to
bf8a677
Compare
cbialorucki
left a comment
There was a problem hiding this comment.
I much prefer what @binarymaster suggested, but it's more important that we fix the download button now than argue about the specific wording
|
I'll squash the first 2 commits (the original commit + the "** use Release Medium..." one) together if you guys are OK with the suggestion. |
| <div class="text-center"> | ||
| <a id="bootcd" class="buttons" href="https://sourceforge.net/projects/reactos/files/latest/download"><div class="btn btn-primary">Download Boot CD</div></a> | ||
| <p>Alternatively, you can download <a id="livecd" class="modalbtn" href="https://sourceforge.net/projects/reactos/files/ReactOS/0.4.15/ReactOS-{{< reactos-download-version >}}-x86-live.zip/download">LiveCD</a></p> | ||
| <a id="bootcd" class="modalbtn" href="https://sourceforge.net/projects/reactos/files/latest/download"><div class="btn btn-primary">Download Installation Medium</div></a> |
There was a problem hiding this comment.
It would be probably still better on the button, but then the text above it should be modified somehow.
…reactos#138) ReactOS commit reactos/reactos@b2e33f2 removed the separate livecd artifact, merging it with the bootcd. Rename also "bootcd" to "Release Image", since it's more generic (e.g. the ISO can be flashed onto an USB thumb drive). The text of the download.html page is reworded to explain what the "Release Image" does.
bf8a677 to
fc40844
Compare
cbialorucki
left a comment
There was a problem hiding this comment.
I would do something like this:
|
|
||
| <div class="text-center"> | ||
| <h2>Discover our latest and greatest</h2> | ||
| <h1>React<span class="text-ros">OS</span> {{< reactos-version >}}</h1> |
| <div class="text-center"> | ||
| <a id="bootcd" class="buttons" href="https://sourceforge.net/projects/reactos/files/latest/download"><div class="btn btn-primary">Download Boot CD</div></a> | ||
| <p>Alternatively, you can download <a id="livecd" class="modalbtn" href="https://sourceforge.net/projects/reactos/files/ReactOS/0.4.15/ReactOS-{{< reactos-download-version >}}-x86-live.zip/download">LiveCD</a></p> | ||
| <a id="bootcd" class="modalbtn" href="https://sourceforge.net/projects/reactos/files/latest/download"><div class="btn btn-primary">Download Release Image</div></a> |
There was a problem hiding this comment.
| <a id="bootcd" class="modalbtn" href="https://sourceforge.net/projects/reactos/files/latest/download"><div class="btn btn-primary">Download Release Image</div></a> | |
| <a id="bootcd" class="modalbtn" href="https://sourceforge.net/projects/reactos/files/latest/download"><div class="btn btn-primary">Download ReactOS {{< reactos-version >}}</div></a> |
There was a problem hiding this comment.
@cbialorucki You mean:
Download our latest and greatest
< ReactOS 0.4.16 >
instead of:
Discover our latest and greatest
< whatever here >
?
There was a problem hiding this comment.
No I mean:
Discover our latest and greatest
< Download ReactOS 0.4.16 >
There was a problem hiding this comment.
+1, this wording looks better for me too. IMHO, it's already obviously that with the main "Download" button, release image can be downloaded.
There was a problem hiding this comment.
You need a verb in the button, it's trying to get you to do something
There was a problem hiding this comment.
It sounds nice and correct. The button is on a separate line, so it gets read as a separate sentence.
Consider this verbal example from Windows XP Tour:
"Experience the best
Experience Windows XP"
There was a problem hiding this comment.
in the XP tour, "the best" is considered a noun there, like, "This is the best.", not as some sort of adjective.
Is this also how you was understanding "our latest and greatest", in your suggestion?
There was a problem hiding this comment.
Hermes both those suggestions read horribly. The second one is a little better but both are bad.
There was a problem hiding this comment.
@cbialorucki feel free to make a new PR :)
ReactOS commit reactos/reactos@b2e33f2 removed the separate livecd artifact, merging it with the bootcd. Rename also "bootcd" to "Installation Medium", since it's more generic (e.g. the ISO can be flashed onto an USB thumb drive).
The text of the download.html is reworded to explain what the "Installation Medium" does.
I've also fixed the Download button, following commit f628d73 (PR #142).
The page: https://pr138.web-content.reactos.org/download/