Exclude local screenshot baselines from iOS Maestro Cloud - #58440
Open
cortinico wants to merge 1 commit into
Open
Exclude local screenshot baselines from iOS Maestro Cloud#58440cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
Summary: Exclude Maestro flows tagged local-screenshot-baseline from iOS Cloud runs, matching the Android Cloud configuration. Cloud devices use different viewport dimensions from the local simulator used to capture these baselines. Changelog: [INTERNAL] [FIXED] - Exclude local screenshot baselines from iOS Maestro Cloud Test Plan: - git diff --check - ./node_modules/.bin/prettier --check .github/workflows/test-all.yml
cortinico
marked this pull request as ready for review
September 10, 2026 10:24
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D119483562. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Exclude Maestro flows tagged
local-screenshot-baselinefrom iOS Cloud runs, matching the Android Cloud configuration. Maestro Cloud uses a different iOS device viewport from the local simulator used to capture these baselines. This currently makestext-width-modefail before image comparison because the expected crop is 960x489 while the Cloud crop is 664x328.Changelog:
[INTERNAL] [FIXED] - Exclude local screenshot baselines from iOS Maestro Cloud
Test Plan:
git diff --check— passed./node_modules/.bin/prettier --check .github/workflows/test-all.yml— passedlocal-screenshot-baseline