fix(ios): prevent missing hairlineWidth border strokes at subpixel Y … - #58162
fix(ios): prevent missing hairlineWidth border strokes at subpixel Y …#58162shashikant-panchal wants to merge 1 commit into
Conversation
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for the fix. I can try to import this as it makes sense on paper, but it might alter how the app behaves. Next release (0.88) is going to be a non breaking change releases, so we have to wait to land this change after we cut the branch (7th of Sept)
Summary:
Fixes #58054
Fixes an issue on iOS (Fabric & Legacy renderer) where
StyleSheet.hairlineWidthborder strokes disappeared when views landed at certain subpixel Y offsets. Removedceil()rounding from stretchable border image size calculations inRCTBorderDrawing.mand updatedCALayer.contentsCentercalculation inRCTViewComponentView.mmandRCTView.mto compute cap sizes dynamically.Changelog:
[IOS] [BREAKING] - Prevent StyleSheet.hairlineWidth border strokes from disappearing at subpixel Y offsets (#58054) - althought this is a fix, it alters how the apps renders.
Test Plan:
borderBottomWidth: StyleSheet.hairlineWidthat various fractional Y offsets (y = 100.1,100.333,100.5,100.7).@2x(0.5pt) and@3x(0.333pt) displays at all offsets.