Add stable public Debug C++ entry point (#58160) - #58160
Open
j-piasecki wants to merge 2 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116930195. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 27, 2026
Summary: Pull Request resolved: react#58160 Pull Request resolved: react#58053 Add `<React/Debug.h>` as the canonical public C++ entry point for React Native's debug assertion macros: `react_native_assert`, `react_native_expect`, and the `REACT_NATIVE_DEBUG` / `REACT_NATIVE_PRODUCTION` flags. Guard direct leaf-header inclusion for strict API consumers while preserving existing React Native builds and legacy include paths. Classify the `redbox/` headers as private instead. They live in namespace `unstable_redbox`, have no consumers outside React Native, and are reachable only from three dev-menu `.mm` files, so they are fenced off with the private guard and deliberately left out of the umbrella. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116930195
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D116930195
branch
from
August 27, 2026 08:13
13696f6 to
9a377d7
Compare
Summary: Add `<React/CallInvoker.h>` as the canonical public C++ entry point for `CallInvoker`, `NativeMethodCallInvoker`, and `SchedulerPriority`. Guard direct leaf-header inclusion for strict API consumers while preserving existing React Native builds and legacy include paths. Export and stage the umbrella consistently through Buck, CMake, Android Prefab, CocoaPods, and the Apple prebuilt-header inventory. SwiftPM needs no change, since its header mapping for this module already preserves the directory structure. The `ios-prebuild` header configuration needs an explicit entry here: the generic podspec parser only reads the first `header_dir`, so it would have flattened the umbrella into `ReactCommon/` and collided with the existing leaf header of the same basename. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116921026
Summary: Add `<React/Debug.h>` as the canonical public C++ entry point for React Native's debug assertion macros: `react_native_assert`, `react_native_expect`, and the `REACT_NATIVE_DEBUG` / `REACT_NATIVE_PRODUCTION` flags. Guard direct leaf-header inclusion for strict API consumers while preserving existing React Native builds and legacy include paths. Classify the `redbox/` headers as private instead. They live in namespace `unstable_redbox`, have no consumers outside React Native, and are reachable only from three dev-menu `.mm` files, so they are fenced off with the private guard and deliberately left out of the umbrella. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116930195
j-piasecki
force-pushed
the
export-D116930195
branch
from
August 28, 2026 06:17
9a377d7 to
abd4067
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add
<React/Debug.h>as the canonical public C++ entry point for React Native's debug assertion macros:react_native_assert,react_native_expect, and theREACT_NATIVE_DEBUG/REACT_NATIVE_PRODUCTIONflags. Guard direct leaf-header inclusion for strict API consumers while preserving existing React Native builds and legacy include paths.Classify the
redbox/headers as private instead. They live in namespaceunstable_redbox, have no consumers outside React Native, and are reachable only from three dev-menu.mmfiles, so they are fenced off with the private guard and deliberately left out of the umbrella.Changelog:
[Internal]
Reviewed By: cipolleschi
Differential Revision: D116930195