Remove unimplemented sendIntent from RCTLinkingManager - #58154
Open
christophpurrer wants to merge 1 commit into
Open
Remove unimplemented sendIntent from RCTLinkingManager#58154christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
Summary:
`sendIntent` is an Android-only Linking API. On iOS the JS layer never reaches
the native module at all — `Linking.sendIntent()` returns
`Promise.reject(new Error('Unsupported'))` for any non-Android platform, so the
exported ObjC method was unreachable. Its body was only
`RCTLogError(@"Not implemented: ...")`.
It is also absent from `NativeLinkingManagerSpec`, the codegen'd protocol
`RCTLinkingManager` conforms to, so a TurboModule call could not dispatch to it
either: only spec methods appear on `NativeLinkingManagerSpecJSI`. The
`sendIntent` declaration lives on the separate Android spec instead.
Removing the dead stub. No behaviour change — the JS-visible rejection on iOS is
produced in `Linking.js` and is untouched.
Changelog: [Internal]
Differential Revision: D117534390
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117534390. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
sendIntentis an Android-only Linking API. On iOS the JS layer never reachesthe native module at all —
Linking.sendIntent()returnsPromise.reject(new Error('Unsupported'))for any non-Android platform, so theexported ObjC method was unreachable. Its body was only
RCTLogError(@"Not implemented: ...").It is also absent from
NativeLinkingManagerSpec, the codegen'd protocolRCTLinkingManagerconforms to, so a TurboModule call could not dispatch to iteither: only spec methods appear on
NativeLinkingManagerSpecJSI. ThesendIntentdeclaration lives on the separate Android spec instead.Removing the dead stub. No behaviour change — the JS-visible rejection on iOS is
produced in
Linking.jsand is untouched.Changelog: [Internal]
Differential Revision: D117534390