Add conic gradients to View backgroundImage - #58143
Draft
Stringsaeed wants to merge 3 commits into
Draft
Conversation
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
TL;DR
Adds
conic-gradient()support toView'sbackgroundImagestyle on iOS and Android.Supported syntax includes:
from <angle>at <position>, including four-value edge offsetsImplementation
ConicGradientgraphics model and serialization.CAGradientLayerwithkCAGradientLayerConicon iOS.SweepGradienton Android.Reviewer guide
Recommended order:
processBackgroundImage.jsCSSBackgroundImage.hConicGradient.h/.cppBackgroundImagePropsConversions.cppRCTConicGradient.mmConicGradient.ktReactNativeApi.d.tsis generated and can be reviewed mechanically.Scope
This PR does not add:
repeating-conic-gradient()in hslChangelog:
[GENERAL] [ADDED] - Support conic gradients in View backgroundImage.
Test Plan:
yarn flow-check— 0 errorsyarn test-generated-typescript— passedyarn fantom packages/react-native/Libraries/StyleSheet/__tests__/processBackgroundPosition-itest.js— 80 tests passedyarn fantom packages/react-native/Libraries/StyleSheet/__tests__/processBackgroundImage-itest.js— 77 tests passedyarn fantom packages/react-native/Libraries/Components/View/__tests__/View-nativeCSSParsing-itest.js— 6 tests passedyarn fantom packages/react-native/Libraries/Components/View/__tests__/View-itest.js— 224 tests passed across native CSS parsing and C++ prop setter flags./gradlew :packages:rn-tester:android:app:assembleDebug— built successfullyfromrotation, and off-centeratpositioningKnown merge-readiness issue
The change introduces public C++ API surface, but C++ API snapshots are not updated. Local generation fails on Android views with an existing duplicate
fmt::v12::basic_appenderparser error. Regenerate those snapshots in the supported Linux CI environment before final review.