Skip to content

Forward declare JSExecutorFactory in RCTAppSetupUtils (#58134) #58134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Forward declare JSExecutorFactory in RCTAppSetupUtils (#58134) #58134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adc0aec
Cover `jsiexecutor` with Stable API guards (#58133)
j-piasecki Aug 26, 2026
2f86a3b
Forward declare JSExecutorFactory in RCTAppSetupUtils (#58134)
j-piasecki Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@
#endif

#import <ReactCommon/RCTTurboModuleManager.h>
#import <jsireact/JSIExecutor.h>

@protocol RCTDependencyProvider;

// Forward declaration to decrease compilation coupling
namespace facebook::react {
class JSExecutorFactory;
class RuntimeScheduler;
}
} // namespace facebook::react
RCT_EXTERN NSArray<NSString *> *RCTAppSetupUnstableModulesRequiringMainQueueSetup(
id<RCTDependencyProvider> dependencyProvider);

Expand Down
1 change: 1 addition & 0 deletions packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#import "RCTAppSetupUtils.h"

#import <cxxreact/JSExecutor.h>
#import <react/renderer/runtimescheduler/RuntimeScheduler.h>
#import <react/renderer/runtimescheduler/RuntimeSchedulerBinding.h>

Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/jsiexecutor/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ target_include_directories(jsireact PUBLIC .)

target_link_libraries(jsireact
react_cxxreact
react_cxxstableapi
reactperflogger
folly_runtime
glog
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/jsiexecutor/React-jsiexecutor.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ Pod::Spec.new do |s|
s.dependency "React-jsi"
s.dependency "React-jsitooling"
s.dependency "React-perflogger"
s.dependency "React-cxxstableapi"
add_dependency(s, "React-debug")
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <cxxreact/JSBigString.h>
#include <cxxreact/JSExecutor.h>
#include <cxxreact/RAMBundleRegistry.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsiexecutor/jsireact/JSINativeModules.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#ifndef RCT_REMOVE_LEGACY_ARCH

#include <memory>
Expand Down
Loading