Skip to content

Add pnpm-lock.yaml to default lock files in autolinkLibrariesFromCommand - #58128

Open
JoelTowell wants to merge 1 commit into
react:mainfrom
JoelTowell:add-pnpm-lock-auto-link-from-command
Open

Add pnpm-lock.yaml to default lock files in autolinkLibrariesFromCommand#58128
JoelTowell wants to merge 1 commit into
react:mainfrom
JoelTowell:add-pnpm-lock-auto-link-from-command

Conversation

@JoelTowell

Copy link
Copy Markdown

Summary:

Android autolinking caches the output of npx @react-native-community/cli config so Gradle does not rerun it on every build. The cache is considered stale when certain files change, currently only yarn.lock, package-lock.json, package.json, and react-native.config.js by default.

Notably, pnpm-lock.yaml is absent from that list, so a pnpm install that only touched the pnpm lockfile would keep using the old cache. Native libraries could be missing or stale until something else forced a refresh.

This PR adds pnpm-lock.yaml to the default list in autolinkLibrariesFromCommand:

.files(
  "yarn.lock",
  "package-lock.json",
  "package.json",
  "react-native.config.js",
  "pnpm-lock.yaml"
)

If a project already passes its own lockFiles, that override still wins, this only changes the default.

It appears that SwiftPM iOS is already checking pnpm-lock.yaml to determine staleness here, so this change just brings Android in line with that.

Changelog:

[ANDROID] [FIXED] - Invalidate the Android autolinking cache when pnpm-lock.yaml changes

Test Plan:

I didn't run ./gradlew test as suggested here because settings.gradle.kts in repo root overrides lockFiles, so RNTester would not hit the new default anyway.

Ran the gradle-plugin unit tests:

yarn --cwd packages/gradle-plugin test

Output:

$ ./gradlew check

BUILD SUCCESSFUL in 2m 11s
22 actionable tasks: 7 executed, 15 up-to-date
Consider enabling configuration cache to speed up this build: https://docs.gradle.org/9.4.1/userguide/configuration_cache_enabling.html
✨  Done in 131.90s.

@meta-cla

meta-cla Bot commented Aug 25, 2026

Copy link
Copy Markdown

Hi @JoelTowell!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Aug 25, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2026
@meta-cla

meta-cla Bot commented Aug 25, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant