Skip to content

Cover react/nativemodule/dom with Stable API guards (#58127) #58127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Cover react/nativemodule/dom with Stable API guards (#58127) #58127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/nativemodule/dom/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ add_library(react_nativemodule_dom
target_include_directories(react_nativemodule_dom PUBLIC ${REACT_COMMON_DIR})

target_link_libraries(react_nativemodule_dom
react_cxxstableapi
rrc_root
react_codegen_rncore
react_cxxreact
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/nativemodule/dom/NativeDOM.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <string>

#if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/nativemodule/dom/React-domnativemodule.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Pod::Spec.new do |s|
s.dependency "React-Fabric"
s.dependency "React-Fabric/bridging"
s.dependency "React-FabricComponents"
s.dependency "React-cxxstableapi"
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
add_dependency(s, "React-graphics", :additional_framework_paths => ["react/renderer/graphics/platform/ios"])
add_dependency(s, "React-RCTFBReactNativeSpec")
Expand Down
Loading