Stop framework headers from exposing private performance APIs (#58011) - #58117
Open
j-piasecki wants to merge 2 commits into
Open
Stop framework headers from exposing private performance APIs (#58011)#58117j-piasecki wants to merge 2 commits into
j-piasecki wants to merge 2 commits into
Conversation
…8116) Summary: Adds private guards to `react/performance/timeline:timeline` and `react/performance/cdpmetrics:cdpmetrics` headers preventing from inclusions when `RN_STABLE_API` is turned on. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D109558177
…58011) Summary: Move private performance includes out of framework-facing scheduler headers and into their implementation files. Store the conditional CDP reporters behind unique pointers so their declarations can remain private implementation details. Changelog: [Internal] Reviewed By: javache Differential Revision: D116621742
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116621742. |
facebook-github-tools
Bot
added
p: Software Mansion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move private performance includes out of framework-facing scheduler headers and into their implementation files. Store the conditional CDP reporters behind unique pointers so their declarations can remain private implementation details.
Changelog: [Internal]
Reviewed By: javache
Differential Revision: D116621742