Skip to content

Clear NetworkReporter timing data for failed requests - #58115

Open
ivory-code wants to merge 1 commit into
react:mainfrom
ivory-code:fix/network-reporter-failed-request-cleanup
Open

Clear NetworkReporter timing data for failed requests#58115
ivory-code wants to merge 1 commit into
react:mainfrom
ivory-code:fix/network-reporter-failed-request-cleanup

Conversation

@ivory-code

@ivory-code ivory-code commented Aug 25, 2026

Copy link
Copy Markdown

Summary:

NetworkReporter stores PerformanceResourceTiming metadata when a request starts and removes it when the response completes. Failed or cancelled requests did not remove that metadata, so each failure left an entry in the process-wide timing buffer. If a request ID was reused, the retained entry could also be reported for the later request.

This clears incomplete resource timing metadata from reportRequestFailed in all builds while preserving the existing CDP failure event. The public C++ method signature remains unchanged.

A regression test reuses a failed request ID and verifies that the completed retry reports its own URL.

Changelog:

[GENERAL] [FIXED] - Clear retained resource timing metadata when network requests fail.

Test Plan:

  • yarn clang-format packages/react-native/ReactCommon/react/networking/NetworkReporter.cpp packages/react-native/ReactCommon/react/networking/NetworkReporter.h packages/react-native/ReactCommon/jsinspector-modern/tests/NetworkReporterTest.cpp
  • ./gradlew ':packages:react-native:ReactAndroid:buildCMakeDebug[arm64-v8a][hermestooling,jsi,etc]' --no-daemon --max-workers=2 --console=plain
    • Passed: BUILD SUCCESSFUL
  • Added testFailedRequestDiscardsResourceTimingData to cover failure cleanup and request ID reuse.
  • The OSS Gradle/CMake setup does not expose the NetworkReporterTest C++ test target locally; that test was not executed locally.

@meta-cla

meta-cla Bot commented Aug 25, 2026

Copy link
Copy Markdown

Hi @ivory-code!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@ivory-code
ivory-code marked this pull request as ready for review August 25, 2026 07:59
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2026
@meta-cla

meta-cla Bot commented Aug 25, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant