Clear NetworkReporter timing data for failed requests - #58115
Conversation
|
Hi @ivory-code! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
NetworkReporterstoresPerformanceResourceTimingmetadata when a request starts and removes it when the response completes. Failed or cancelled requests did not remove that metadata, so each failure left an entry in the process-wide timing buffer. If a request ID was reused, the retained entry could also be reported for the later request.This clears incomplete resource timing metadata from
reportRequestFailedin all builds while preserving the existing CDP failure event. The public C++ method signature remains unchanged.A regression test reuses a failed request ID and verifies that the completed retry reports its own URL.
Changelog:
[GENERAL] [FIXED] - Clear retained resource timing metadata when network requests fail.
Test Plan:
yarn clang-format packages/react-native/ReactCommon/react/networking/NetworkReporter.cpp packages/react-native/ReactCommon/react/networking/NetworkReporter.h packages/react-native/ReactCommon/jsinspector-modern/tests/NetworkReporterTest.cpp./gradlew ':packages:react-native:ReactAndroid:buildCMakeDebug[arm64-v8a][hermestooling,jsi,etc]' --no-daemon --max-workers=2 --console=plainBUILD SUCCESSFULtestFailedRequestDiscardsResourceTimingDatato cover failure cleanup and request ID reuse.NetworkReporterTestC++ test target locally; that test was not executed locally.