Fix 'stopForegroundService' method - #742
Merged
Merged
Conversation
3 tasks
sboily
approved these changes
Sep 14, 2026
sboily
left a comment
sboily
left a comment
Member
There was a problem hiding this comment.
Reviewed at 3e8d55b. This correctly replaces the invalid notification-behavior flag with STOP_FOREGROUND_REMOVE and is compatible with #875 and #876. We reproduced the notification cleanup defect and validated the equivalent fix in our React Native 0.87.1 host app on Samsung SM-S921W (API 36) and Pixel Tablet (API 37).
Two pre-existing issues remain for follow-up: guard stopForeground(int) on API 23 with stopForeground(true), and stop the foreground service only after the last connection ends. This PR introduces neither issue; our mobile integration already handles both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect use of Service.stopForeground.