Guard host userdata identity against stale-reference reuse - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a regression guard for the failure mode reported in scoder/lupa#294.
Lupa's Lua 5.5 bug came from reusing a cached host-object reference slot before the old Lua userdata wrapper had actually been collected, allowing a stale wrapper to resolve to a different live Python object.
LuaPyre currently avoids that mechanism entirely: opaque host userdata is represented by the Python object reference itself rather than a recyclable registry handle. This PR makes that an explicit invariant and locks it in with stress coverage.
Changes:
LuaRuntime._to_lua()that reusable host-reference registries must use identity/generation validation on reuse and finalizationValidation:
Reference: