fix(consent): store no consent on a flow that can never record one - #1920
Open
rohanchkrabrty wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedNext included review available in 55 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rohanchkrabrty
requested review from
AmanGIT07
and removed request for
Shreyag02
September 3, 2026 17:29
Coverage Report for CI Build 34157634130Coverage increased (+0.002%) to 50.214%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
rohanchkrabrty
force-pushed
the
fix-dont-store-documents-in-flow-when-consent-disabled
branch
from
September 6, 2026 21:42
2162d36 to
6aaa56a
Compare
rohanchkrabrty
force-pushed
the
fix-dont-store-documents-in-flow-when-consent-disabled
branch
from
September 7, 2026 05:29
6aaa56a to
b2c8429
Compare
rohanchkrabrty
force-pushed
the
fix-dont-store-documents-in-flow-when-consent-disabled
branch
from
September 7, 2026 06:10
b2c8429 to
886ef61
Compare
rohanchkrabrty
force-pushed
the
fix-dont-store-documents-in-flow-when-consent-disabled
branch
from
September 7, 2026 07:12
886ef61 to
6ac11e7
Compare
rohanchkrabrty
force-pushed
the
fix-dont-store-documents-in-flow-when-consent-disabled
branch
from
September 7, 2026 19:58
6ac11e7 to
8cfce91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flows.metadatawhenever a caller sentaccepted_document_ids, with no check on whether the deployment asks for consent, or whether the intent could ever produce a record.app.consentdisabled, and a login under any config, therefore persisted unvalidated client ids alongside the caller's IP and a timestamp under a key namedconsent— for a record that is never written.gateFlowConsentalready resolves the ids, so it now returns what they resolved to and the write is keyed off that. Nothing resolves with consent disabled, on a login, or with the service unwired, so none of the three carries a block.user_consentsandaudit_recordsneeded no change — both are reachable only through the branchcreateUsertakes whenResolveAllreturns documents, which is empty when consent is disabled.