RavenDB-27141 Catch NoLeaderException by type and release 7.2.6.post1 - #24
Merged
poissoncorp merged 1 commit intoSep 17, 2026
Merged
Conversation
Client 7.2.6.post1 maps the server's NoLeaderException correctly, so the text fallback that stood in for it can go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client 7.2.6.post1 types the server's
NoLeaderException, so the string match that stood in for it is gone.Before, the second
except RavenExceptionclause was the only branch that could ever fire, because the client mapped the exception under a name the server never sends.The client pin moves to
ravendb~=7.2.6.post1, which is what makes the typed catch reliable. Package version goes to7.2.6.post1.71 tests, all passing against client 7.2.6.post1.