Include the bank's response in FinTSClientPINError - #225
Open
bjorn wants to merge 1 commit into
Open
Conversation
The error is raised for any 9xxx response before the dialog is open, so "PIN wrong?" is only one of several possible causes: a product id the bank does not know yet, an expired 90-day web-login requirement (ING), or credentials of the wrong kind. The bank's own code and text say which, but they were dropped, and since the initialisation message is sent with internal_send=True they are not logged either. Put the code and text into the message and expose them as response_code and response_text on the exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FinTSClientPINErroris raised for any 9xxx response before the dialog is open, so "PIN wrong?" is only one of several possible causes: a product id the bank does not know yet, an expired 90-day web-login requirement (ING), or credentials of the wrong kind. The bank's own code and text say which, but they were dropped, and since the initialisation message is sent withinternal_send=Truethey are not logged either. Without DEBUG logging of the raw exchange there is nothing to go on, and every retry counts towards the bank's lockout.This keeps the wording, appends the bank's response to the message, and exposes it as
response_codeandresponse_texton the exception.test_pin_wrongnow asserts on the mock bank's9910 Pin ungültig.Example against ING:
Error during dialog initialization, PIN wrong? Bank response: 9942 - Log-in fehlgeschlagen. 3 Fehlversuche führen zur Sperrung.#222 is a recent instance of the same hunt for a hidden code.