Require julia 1.10 - #65
Open
davidanthoff wants to merge 1 commit into
Open
Conversation
ParquetFiles now reads via Parquet2.jl, which requires julia 1.10. Without raising the floor here too, Queryverse on an older julia cannot resolve the new ParquetFiles and would silently fall back to ParquetFiles 0.2.0, which depends on the Parquet.jl/Thrift/BinaryProvider chain that is no longer installable. The ParquetFiles compat entry already accepts the new version, so the julia floor is the only change needed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParquetFiles now reads via Parquet2.jl (queryverse/ParquetFiles.jl#43), which requires julia 1.10.
Without raising the floor here too, Queryverse on an older julia cannot resolve the new ParquetFiles and would silently fall back to ParquetFiles 0.2.0 — the version that depends on the Parquet.jl → Thrift → BinaryProvider chain that is no longer installable, which is exactly what that change fixes.
The
ParquetFiles = "0.2, 0.3, 1"compat entry already accepts the new version, so the julia floor is the only edit. No source changes.Verified locally: with ParquetFiles#43 dev'd,
using Queryverseloads andDataFrame(load("nation.impala.parquet"))returns the expected 25×4 table.CI cannot go green until ParquetFiles is released
This PR's CI still fails, and that is expected: Queryverse resolves ParquetFiles v0.2.0 from the registry, not the branch in queryverse/ParquetFiles.jl#43. That old release pulls Parquet 0.3.2 → Thrift → BinaryProvider, and the resolver rejects it outright:
Pkg.resolvefails before any test runs. This is exactly the breakage ParquetFiles#43 fixes, so these legs should go green once ParquetFiles 1.0.0 is registered — this PR should be merged/re-run in that order.For reference, Julia CI on
mainis already failing for the same reason (63 of 80 legs). The julia floor bump here shrinks the matrix from 80 legs to 29 but cannot fix the resolution failure on its own.Note also that the 32-bit legs fail independently, on a PyCall/conda i686 build error unrelated to any of the above.