Samsung AI LiteCore - buildsystem: separate backend and example builds. - #22582
Open
Jiseong-oh wants to merge 2 commits into
Open
Samsung AI LiteCore - buildsystem: separate backend and example builds.#22582Jiseong-oh wants to merge 2 commits into
Jiseong-oh wants to merge 2 commits into
Conversation
To keep backend and example artifacts distinct. AS-IS: - The backend library and 'enn_executor_runner' were built together. - The example artifact 'enn_executor_runner' was placed under 'backend/samsung', it is not proper location for example artifacts. TO-BE: - Build the backend library first, then let the example projects refer to already-built backend library. - Adjust CMakeLists so that 'enn_executor_runner' is compiled in the 'examples/samsung/' directory and its output is placed in there. Signed-off-by: Jiseong.oh <jiseong.oh@samsung.coms>
- fixed dead/hard build paths - Fixed typo and added NDK path. Signed-off-by: jiseong.oh <jiseong.oh@samsung.com>
Jiseong-oh
requested review from
kirklandsign and
larryliu0820
as code owners
September 5, 2026 06:54
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22582
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7263631 with merge base c570b6c ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Jiseong-oh
added
partner: samsung
This PR needs a
|
Jiseong-oh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To keep backend and example artifacts distinct.
AS-IS:
Test plan
${EXECUTORCH_ROOT}/backends/samsung/build.sh -b all
cc @SS-JIA @digantdesai @kimishpatel