gh-157242: Do not close io.BytesIO on MemoryError - #157344
Merged
Merged
Conversation
Replace _PyBytes_Resize() with _PyBytes_ResizeKeepOnError(). Fix truncate(): only set string_size on resize success.
Revert the string_size change. Instead, restore string_size to its previous value on error.
Member
Author
|
io.StringIO makes the object inconsistent on MemoryError! It looks more complicated to fix it, so I focused this PR on io.BytesIO. |
Member
Author
|
There is still an issue in the Python implementation of I merge this change anyway to make the situation a little bit better. Replacing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace _PyBytes_Resize() with _PyBytes_ResizeKeepOnError().
Fix truncate(): only set string_size on resize success.