gh-157056: Fix STRING format for comprehension and lambda annotations - #157152
Closed
KingLizard1020 wants to merge 12 commits into
Closed
gh-157056: Fix STRING format for comprehension and lambda annotations#157152KingLizard1020 wants to merge 12 commits into
KingLizard1020 wants to merge 12 commits into
Conversation
…ations get_annotations(..., format=Format.STRING) raised ValueError on dict comprehension annotations because fake-globals iteration cannot unpack pair targets. Recover the annotation text from source in that case. Lambda and generator-expression annotations are syntax, so they were stringified with repr() and leaked a memory address. Prefer the source text when available, and use a stable type_repr() otherwise.
Only consult source when fake-globals cannot stringify. Limit the ValueError handler to unpack errors, keep class-body control-flow annotations, and avoid requoting string-literal annotations.
Only consult source when fake-globals cannot stringify. Limit the ValueError handler to unpack errors, keep class-body control-flow annotations, and avoid requoting string-literal annotations.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Withdrawing. The issue was closed as a documented STRING-format limitation, so this heuristic is not the direction the maintainers want.