gh-63102: Support custom targets in the pull parser - #156888
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-63102: Support custom targets in the pull parser#156888serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
The list of events was collected by the TreeBuilder in the C implementation, so the pull parser only worked with the standard target. The parser itself now collects the events, and reports what the target returns. XMLPullParser and iterparse() get the target parameter, which makes it possible to parse a large document incrementally without building a tree for it. The namespace events no longer need a separate code path: the parser reports the prefix and the uri if the target does not implement start_ns()/end_ns(), as the Python implementation already did.
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the C implementation the list of events was collected by the
TreeBuilder, so the pull parser only worked with the standard target. The parser itself now collects the events and reports what the target returns.XMLPullParseranditerparse()get the target parameter, which makes it possible to parse a large document incrementally without building a tree for it.The namespace events no longer need a separate code path: the parser reports the prefix and the URI if the target does not implement
start_ns()andend_ns(), as the Python implementation already did.