gh-156698: Fix _ProactorDatagramTransport never resumes a paused protocol after a write error - #156718
Open
graingert wants to merge 3 commits into
Open
gh-156698: Fix _ProactorDatagramTransport never resumes a paused protocol after a write error#156718graingert wants to merge 3 commits into
_ProactorDatagramTransport never resumes a paused protocol after a write error#156718graingert wants to merge 3 commits into
Conversation
graingert
changed the title
_ProactorDatagramTransport never resumes a paused protocol after a write error
graingert
changed the title
_ProactorDatagramTransport never resumes a paused protocol after a write error_ProactorDatagramTransport never resumes a paused protocol after a write error
graingert
marked this pull request as ready for review
August 31, 2026 15:18
graingert
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
August 31, 2026 15:18
graingert
force-pushed
the
fix-proactor-error-hang
branch
from
August 31, 2026 17:30
a3b797a to
800498e
Compare
graingert
added
needs backport to 3.13
graingert
force-pushed
the
fix-proactor-error-hang
branch
from
September 1, 2026 16:42
800498e to
3006d6e
Compare
graingert
commented
Sep 3, 2026
| if self._buffer and not self._conn_lost: | ||
| # Re-arm the write loop so buffered data isn't stranded and | ||
| # a paused protocol is eventually resumed (gh-156698). | ||
| self._loop.call_soon(self._loop_writing) |
Contributor
Author
There was a problem hiding this comment.
protocol.error_received could call send/sendto and we get a write_fut scheduled which will cause loop_writing's assertion to fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156698
_ProactorDatagramTransportnever resumes a paused protocol after a write error #156698