gh-138978: Fully qualified name for abc classes exception. - #156683
Open
skv0zsneg wants to merge 11 commits into
Open
gh-138978: Fully qualified name for abc classes exception.#156683skv0zsneg wants to merge 11 commits into
skv0zsneg wants to merge 11 commits into
Conversation
skv0zsneg
commented
Aug 30, 2026
|
|
||
| def check_program_exitcode(self, *args, check_stderr=True, **kwargs): | ||
| out, err = self.run_embedded_interpreter(*args, **kwargs) | ||
| self.assertEqual(out.rstrip(), 'ok! Py_RunMain() returned 123') |
Contributor
Author
There was a problem hiding this comment.
After adding changes to tests and typeobjec.c the strange error appear
AssertionError: 'Cmd click to launch VS Code Native REPL\nok! Py_RunMain() returned 123' != 'ok! Py_RunMain() returned 123'
- Cmd click to launch VS Code Native REPL
ok! Py_RunMain() returned 123
So, I changed it for checking exactly "ok!..." string.
Contributor
There was a problem hiding this comment.
Could you check if it happens from CLI? My hunch is that it's VS Code artifact
Contributor
Author
There was a problem hiding this comment.
Wow, yes. From CLI test is not falling.
I do not clearly understand what this test (and others in Lib/test/test_embed.py) checking. Integrations with IDE's?
maurycy
reviewed
Aug 31, 2026
maurycy
left a comment
Contributor
There was a problem hiding this comment.
I suspect that the C part can be a bit smaller, using %N
cpython/Objects/unicodeobject.c
Lines 3019 to 3049 in aad4288
maurycy
reviewed
Aug 31, 2026
skv0zsneg
force-pushed
the
fix-issue-138978
branch
from
September 5, 2026 21:40
cd64d2c to
7cd3e34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeError#138978