gh-156353: Fix configparser space delimiter parsing - #156382
Open
sundeep8967 wants to merge 3 commits into
Open
Conversation
This commit fixes a bug introduced in pythongh-146333 where using a space as a delimiter would cause the option name parsing to incorrectly absorb the space. The regular expressions _OPT_TMPL and _OPT_NV_TMPL have been adjusted to ensure that whitespace matches do not consume valid delimiters. Signed-off-by: sundeep8967 <sundeep8967@gmail.com>
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Signed-off-by: sundeep8967 <sundeep8967@gmail.com>
…om options Signed-off-by: sundeep8967 <sundeep8967@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Between Python 3.14.4 and 3.14.5 (and similarly in 3.13),
configparserstopped recognizing a space as a delimiter whendelimiters=(' ', '=')was used. This regression was caused by gh-146333 which addressed a ReDoS vulnerability in the option parsing regex but inadvertently allowed the greedy\s+inside the option name group to consume whitespace characters even if they were valid delimiters.Solution
This PR adjusts
_OPT_TMPLand_OPT_NV_TMPLto explicitly ensure that any whitespace character consumed as part of the option name is NOT a valid delimiter ((?:(?!{delim})\s)+).This retains the catastrophic backtracking protection introduced in gh-146333 (the mutually exclusive possessive-like parsing structure remains intact) while restoring the ability to use spaces as delimiters.