gh-156371: Fix missing PyRefTracer_DESTROY events for trashcan objects - #156372
Open
corona10 wants to merge 6 commits into
Open
gh-156371: Fix missing PyRefTracer_DESTROY events for trashcan objects#156372corona10 wants to merge 6 commits into
corona10 wants to merge 6 commits into
Conversation
corona10
added
needs backport to 3.13
Member
Author
|
cc @markshannon |
Member
Author
|
cc @vstinner and @iritkatriel who reviewed #132280 :) |
Member
Author
|
I've also added the test code for preventing future regression. |
markshannon
requested changes
Aug 26, 2026
| #ifdef Py_TRACE_REFS | ||
| _Py_ForgetReference(op); | ||
| #endif | ||
| _PyReftracerTrack(op, PyRefTracer_DESTROY); |
Member
There was a problem hiding this comment.
I don't think this is right. This should be in _PyTrash_thread_destroy_chain()
The object is destroyed when the trashcan is emptied, not when the object is deposited.
Member
Author
There was a problem hiding this comment.
Okay, it sounds better and I've applied your suggestion.
|
When you're done making the requested changes, leave the comment: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.