Skip to content

Fix file:\\ URL handling in urllib on Windows #156356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aryansk wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix file:\\ URL handling in urllib on Windows #156356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Lib/urllib/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,6 +1681,11 @@ def url2pathname(url, *, require_scheme=False, resolve_host=False):
"""
if not require_scheme:
url = 'file:' + url
# Handle Windows file URLs with backslashes like file:\\C:\path
# (as used in some browsers and in the wild). Normalize to forward
# slashes before parsing so urlsplit treats it as file://.
if url.lower().startswith('file:'):
url = url.replace('\\', '/')

@edvilme edvilme Aug 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to just replace file:\\ with file:// on Windows only to avoid accepting invalid uris like file://Users/edvilme\somepath

scheme, authority, url = urlsplit(url)[:3] # Discard query and fragment.
if scheme != 'file':
raise URLError("URL is missing a 'file:' scheme")
Expand Down
Loading