Conversation
…dency to ~=20.0 and adjust tests for v20 immutability
xuu33030
changed the title
harshil21
reviewed
Sep 20, 2026
Comment on lines
+18
to
+22
| "Lorem Ipsum is simply dummy text of the printing and typesetting industry. " | ||
| "Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an " | ||
| "unknown printer took a galley of type and scrambled it to make a type specimen book. " | ||
| "It has survived not only five centuries, but also the leap into electronic typesetting, " | ||
| "remaining essentially unchanged." |
Member
There was a problem hiding this comment.
This needs to be updated from https://www.lipsum.com/ :)
Member
There was a problem hiding this comment.
Do you mind also changing the List to list in the extracturls.py file? If I saw correctly that should make it compatible with py3.10+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_urlsandlongbotcommanddependencies to Python Telegram Bot 20.xLongBotCommandexample to the PTB 20 asyncApplicationAPIRoot cause
Issue #131 identified two contributions that still depended on PTB v13 APIs.
longbotcommandalso had tests that attempted to mutateBotCommand.description, which is immutable in PTB v20.Verification
python run_tests.py -n extract_urls longbotcommand— 14 passedApplicationsuccessfully without starting pollinggit diff --check— passedCloses #131