Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the end of
putpalette(), there isPillow/src/PIL/Image.py
Line 2173 in d13f288
If we take 'install' to mean 'copy into C', in terms of our big picture, there's no reason why that needs to be done. Every time Pillow goes to access C image data,
load()is called first, so that copying could be lazily deferred.What it is doing of immediate consequence is decoding the palette data from the raw mode into the mode. So this PR changes
load()to only run if the palette data needs decoding.At the same time, I will continue the principle of #10002 by not assigning a RGBA rawmode to an RGBA palette in
putpalette(), and similarly for CMYK. So RGBA and CMYK raw mode palettes can have theirload()operations lazily deferred as well.