Re-enable passing HSLA/HSBA getter tests in p5.Color - #9166
Open
Shruti2110-coder wants to merge 1 commit into
Open
Re-enable passing HSLA/HSBA getter tests in p5.Color#9166Shruti2110-coder wants to merge 1 commit into
Shruti2110-coder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9139
Five
test.todo→testin test/unit/color/p5.Color.js (lines 467, 490, 517,637, 685). No source changes.
These were disabled in 7af4967 ("Mark most failing tests as todos", Sep 2024)
during the 2.0 work and pass on current main. They cover the HSL/HSB getters
reached via three different string-parsing paths (rgba(), hsla(), hsba()).
Verified against current main after rebase:
npm run lintunchanged at 6 warnings / 0 errors_getHue()is deliberately broken(
AssertionError: expected 999 to be close to 336 +/- 0.5), so they exercisethe code rather than passing vacuously
Left alone: line 252's
suite.todo('invalid string')has no body and is agenuinely unwritten test.