Skip to content

Re-enable passing HSLA/HSBA getter tests in p5.Color - #9166

Open
Shruti2110-coder wants to merge 1 commit into
processing:mainfrom
Shruti2110-coder:reenable-color-todo-tests
Open

Re-enable passing HSLA/HSBA getter tests in p5.Color#9166
Shruti2110-coder wants to merge 1 commit into
processing:mainfrom
Shruti2110-coder:reenable-color-todo-tests

Conversation

@Shruti2110-coder

Copy link
Copy Markdown

Resolves #9139

Five test.todotest in test/unit/color/p5.Color.js (lines 467, 490, 517,
637, 685). No source changes.

These were disabled in 7af4967 ("Mark most failing tests as todos", Sep 2024)
during the 2.0 work and pass on current main. They cover the HSL/HSB getters
reached via three different string-parsing paths (rgba(), hsla(), hsba()).

Verified against current main after rebase:

  • test/unit/color/p5.Color.js passes 97/97
  • npm run lint unchanged at 6 warnings / 0 errors
  • The five fail as expected when _getHue() is deliberately broken
    (AssertionError: expected 999 to be close to 336 +/- 0.5), so they exercise
    the code rather than passing vacuously

Left alone: line 252's suite.todo('invalid string') has no body and is a
genuinely unwritten test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable 5 passing .todo tests in test/unit/color/p5.Color.js

1 participant