Skip to content

fix(web): go back with Escape from Usage and Pull Requests - #10393

Closed
Neel2107 wants to merge 1 commit into
pingdotgg:mainfrom
Neel2107:fix/page-escape-navigation-10388
Closed

Neel2107 wants to merge 1 commit into
pingdotgg:mainfrom
Neel2107:fix/page-escape-navigation-10388

Conversation

@Neel2107

@Neel2107 Neel2107 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Escape returned from Settings but did nothing on Usage and Pull Requests. Reuse the shared back-navigation hooks from #10158 across all three pages and the sidebar Back button. Editors and popovers that consume Escape still dismiss first.

Fixes #10388. Overlaps with #10158 for Usage and the shared hooks; this also covers Pull Requests, without adding Usage shortcuts.

Validated with 17 focused tests, web typecheck, formatting, and a desktop build. Targeted lint reported existing warnings only. Reporter tested both pages in the local macOS desktop app.

Desktop verification

escape-navigation-desktop.mov

Created with GPT-6 in Codex in T3 Code

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 6, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a focused keyboard-navigation fix that reuses existing back-navigation behavior across Settings, Usage, Pull Requests, and the sidebar. The new event handling is small, isolated, and covered by dedicated tests, with no schema, deployment, product-default, or static-analysis changes.

Not approved because:

  • Monthly spending limit reached (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

@Neel2107

Neel2107 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #10158, which now covers Escape navigation on both Usage and Pull Requests. Thanks for adding the missing surface!

The regression tests in apps/web/src/hooks/useNavigateBack.test.tsx here may be useful to carry over. #10388 should remain open until the fix merges.

@Neel2107 Neel2107 closed this Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Escape does not return to the previous thread from Pull Requests or Usage

1 participant