Conversation
Contributor
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — This is a focused keyboard-navigation fix that reuses existing back-navigation behavior across Settings, Usage, Pull Requests, and the sidebar. The new event handling is small, isolated, and covered by dedicated tests, with no schema, deployment, product-default, or static-analysis changes. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escape returned from Settings but did nothing on Usage and Pull Requests. Reuse the shared back-navigation hooks from #10158 across all three pages and the sidebar Back button. Editors and popovers that consume Escape still dismiss first.
Fixes #10388. Overlaps with #10158 for Usage and the shared hooks; this also covers Pull Requests, without adding Usage shortcuts.
Validated with 17 focused tests, web typecheck, formatting, and a desktop build. Targeted lint reported existing warnings only. Reporter tested both pages in the local macOS desktop app.
Desktop verification
escape-navigation-desktop.mov
Created with GPT-6 in Codex in T3 Code