Fix PHPParser ArgPlaceholder compat - #329
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The annotations address the reported PHPStan compatibility errors.
Review effort: Lite
Findings: None
What changed in this PR
Updates PHPDoc annotations to support PHP-Parser ArgPlaceholder nodes and resolve PHPStan compatibility errors.
Changes:
- Extends argument types in both assertion rules.
- Preserves support for existing argument node types.
| File | Description |
|---|---|
src/Rules/PHPUnit/AssertSameNullExpectedRule.php |
Updates rewriteArgs() annotations. |
src/Rules/PHPUnit/AssertSameBooleanExpectedRule.php |
Updates rewriteArgs() annotations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
staabm
commented
Sep 19, 2026
| /** | ||
| * @param array<Node\Arg|Node\VariadicPlaceholder> $args | ||
| * @return list<Node\Arg|Node\VariadicPlaceholder> | ||
| * @template T of NodeAbstract |
Contributor
Author
There was a problem hiding this comment.
instead of using a fixed union of types (which depends on PHPParser version) use a more generic base class
PHPParser v5.9.0+: Node\Arg|Node\ArgPlaceholder|Node\VariadicPlaceholder
PHPParser <v5.9.0: Node\Arg|Node\VariadicPlaceholder
VincentLanglet
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes