Skip to content

Allow language mounting & redesign boards from cards to table - #330

Merged
iMattPro merged 8 commits into
phpbb:masterfrom
iMattPro:bind-languages
Sep 1, 2026
Merged

Allow language mounting & redesign boards from cards to table#330
iMattPro merged 8 commits into
phpbb:masterfrom
iMattPro:bind-languages

Conversation

@iMattPro

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds first-class support for mounting phpBB language packs (bind or copy) into sandbox boards, wiring the feature through the CLI, Docker compose generation, unmount cleanup, and the Dashboard UI.

Changes:

  • Introduces LanguageManager (discover/mount/list/unmount) plus a phpBB-bootstrapped LanguageUninstallerWriter used during unmount.
  • Extends compose/entrypoint generation to include language bind mounts and exclude them from ownership find traversal.
  • Updates Dashboard UI, CLI help/docs, and adds unit/integration tests covering language workflows.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/Unit/LanguageManagerTest.php New unit coverage for language discovery/mount/unmount behaviors and validation.
tests/Unit/DockerComposeWriterTest.php Verifies compose/entrypoint output includes language mounts and prune paths.
tests/Unit/CustomisationUnmountServiceTest.php Ensures language uninstall is invoked before unmounting.
tests/Unit/BoardServiceTest.php Asserts new boards include an empty languages config key.
tests/Unit/BoardRunnerTest.php Adds coverage for copying/running the language uninstall script in a container.
tests/Integration/WebApplicationTest.php Updates UI expectations for unified customisation mount and language metrics/listing.
tests/Integration/BinQiTest.php Smoke test for lang:mount command wiring.
tests/Integration/ApplicationTest.php Ensures language commands appear in CLI help output.
src/QuickInstall/Sandbox/Web/templates/dashboard.php Adds Languages mounted group + replaces separate mount forms with unified customisation mount form including Language.
src/QuickInstall/Sandbox/Web/Application.php Adds language managers to view data and supports mounting/unmounting languages (including unified mount action).
src/QuickInstall/Sandbox/LanguageUninstallerWriter.php New writer that generates a phpBB bootstrapped script to uninstall installed languages safely.
src/QuickInstall/Sandbox/LanguageManager.php New manager implementing the customisation manager contract for language packs.
src/QuickInstall/Sandbox/DockerComposeWriter.php Adds language bind volumes and excludes them from ownership find traversal.
src/QuickInstall/Sandbox/CustomisationUnmountService.php Adds language() unmount flow with pre-unmount phpBB cleanup via runner.
src/QuickInstall/Sandbox/CustomisationMountService.php Updates class docblock to “customisations” (no logic change shown).
src/QuickInstall/Sandbox/bootstrap.php Registers new language manager/uninstaller writer in bootstrap includes.
src/QuickInstall/Sandbox/BoardService.php Ensures new/derived board configs include languages: [].
src/QuickInstall/Sandbox/BoardRunner.php Adds uninstallLanguage() which copies/execs the generated uninstall script.
src/QuickInstall/Sandbox/BoardRefreshService.php Adds languages: [] into runtime config defaults.
src/QuickInstall/Sandbox/Application.php Adds lang:* CLI commands and help documentation entries.
public/assets/sandbox-ui.js Preserves viewport position across AJAX dashboard replacement.
public/assets/sandbox-ui.css Adjusts dashboard layout for added Languages metric and unified mount form.
docs/sandbox-cli.md Documents language pack layout, mount/list/unmount workflows, and safety notes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/QuickInstall/Sandbox/Web/templates/dashboard.php
Track mount details in activity entries while using stable form keys to
restore pending state after dashboard refreshes.
@iMattPro iMattPro changed the title Allow language mounting Allow language mounting & redesign boards from cards to table Sep 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated no new comments.

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/QuickInstall/Sandbox/LanguageManager.php:179

  • languageName() reads composer.json via json_decode() but does not validate that decoding succeeded before indexing into $data['extra']. If the JSON is invalid, this will raise a TypeError (offset access on null) instead of a controlled InvalidArgumentException, and can also break discover() via isLanguagePath().
		$data = json_decode((string) file_get_contents($composer), true);
		$name = $data['extra']['language-iso'] ?? null;
		if (!is_string($name) || $name === '')
		{
			throw new InvalidArgumentException("Language composer.json must contain extra.language-iso: $composer");
		}

@iMattPro
iMattPro merged commit a6d7ceb into phpbb:master Sep 1, 2026
6 checks passed
@iMattPro
iMattPro deleted the bind-languages branch September 1, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants