Skip to content

Fix GH-23619: ext/ftp: cryptic error on servers that don't support TL… #23788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndossche wants to merge 1 commit into from
+4 −1
Closed

Fix GH-23619: ext/ftp: cryptic error on servers that don't support TL… #23788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ext/ftp/ftp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1904,7 +1904,10 @@ data_accept(databuf_t *data, ftpbuf_t *ftp)
/* get the session from the control connection so we can re-use it */
session = ftp->last_ssl_session;
if (session == NULL) {
php_error_docref(NULL, E_WARNING, "data_accept: failed to retrieve the existing SSL session");
php_error_docref(NULL, E_WARNING, "data_accept: failed to retrieve the existing SSL session from the control connection. "
"The server does not support TLS session resumption on the data connection, "
"which is necessary to protect against session data stealing. "
"PHP does not support such configuration.");
SSL_free(data->ssl_handle);
return 0;
}
Expand Down
Loading