Skip to content

ext/zip: fix use-after-free in the archive destructor path #23779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvoisin wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

ext/zip: fix use-after-free in the archive destructor path #23779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ext/zip/php_zip.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,7 +1169,13 @@ bool php_zip_archive_release(php_zip_archive *archive)
}

if (archive->za) {
if (zip_close(archive->za) != 0) {
/* Guard against a re-entrant close() or open() from a progress/cancel
* callback fired during zip_close(), which would run a nested zip_close()
* on the same archive (see php_zipobj_close()). */
archive->close = true;
int err = zip_close(archive->za);
archive->close = false;
if (err != 0) {
if (!archive->bailout_callback) {
php_error_docref(NULL, E_WARNING, "Cannot destroy the zip context: %s", zip_strerror(archive->za));
}
Expand Down
Loading