build/gen_stub: include attribute arguments in synopsis modifiers - #22418
Merged
Merged
Conversation
DanielEScherzer
approved these changes
Jun 23, 2026
DanielEScherzer
left a comment
DanielEScherzer
left a comment
Member
There was a problem hiding this comment.
Output at php/doc-en#5631 looks good to me, leaving to mate for final approval
Member
Author
|
Upon closely inspecting all files (php/doc-en@b782ece) I noticed 3 files had Adding |
kocsismate
approved these changes
Jun 25, 2026
Member
Author
|
@DanielEScherzer with the Branch split around the corner, could you merge this? I don't have the rights myself. |
Member
|
@jordikroon Do we need this in PHP 8.4? We'll start to document PHP 8.6 very soon so IMO master is completely fine. |
jordikroon
marked this pull request as draft
September 20, 2026 00:13
jordikroon
force-pushed
the
gen-stub-attribute-args
branch
from
September 20, 2026 00:14
e6f364b to
869abeb
Compare
jordikroon
marked this pull request as ready for review
September 20, 2026 00:14
Member
Author
|
@kocsismate personally don't need it. As long as it will end up in the 8.6 branch / master, I will be happy.
|
kocsismate
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output: php/doc-en#5631