ext/gettext: avoid NULL deref in textdomain/bindtextdomain - #21882
Merged
Merged
Conversation
Member
|
I'm not sure adding |
Member
Author
|
Let me re-do as exception, since it is basically theoretical (i reproduced via fake lib via LD_PRELOAD) has a plus of not changing return type. |
iliaal
force-pushed
the
gettext-null-deref-hardening-8.4
branch
from
April 27, 2026 12:26
b7039f2 to
ee25047
Compare
iluuu1994
approved these changes
Sep 19, 2026
iluuu1994
left a comment
iluuu1994
left a comment
Member
There was a problem hiding this comment.
LGTM, but maybe target master.
Both functions can return NULL on libintl-internal allocation failure, which RETURN_STRING then fed to strlen(NULL) and crashed. Throw an Error in that case instead, leaving the existing string return type intact (no static-analysis fallout from a widened signature). The dir==NULL query path of bindtextdomain keeps its RETURN_FALSE because musl returns NULL there to signal an unbound domain, which is not an error condition.
iliaal
force-pushed
the
gettext-null-deref-hardening-8.4
branch
from
September 19, 2026 22:23
ee25047 to
8f0f1b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
textdomain()andbindtextdomain($domain, $dir)can return NULL on libintl-internal allocation failure. RETURN_STRING then calls strlen(NULL) and crashes. Throw anErrorin that case instead. Return signatures stay asstringso static analyzers don't pick up new false branches.