Conversation
jeregrine
force-pushed
the
advertise-relup-callback-modules
branch
from
September 15, 2026 14:48
435b7f7 to
a0cdffa
Compare
jeregrine
force-pushed
the
advertise-relup-callback-modules
branch
from
September 15, 2026 15:05
a0cdffa to
7f8b9a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OTP's release handler discovers processes to suspend and pass through
code_change/3from each supervisor child specification'smoduleslist. DurableServer children currently advertise only the genericDurableServerwrapper, so a release upgrade that changes a user callback module cannot associate that module with its running durable processes.That leaves callback-owned runtime state outside the normal relup migration path.
Fix
Advertise both
DurableServerand the user callback module in each durable child'smoduleslist. The wrapper remains the process callback and continues delegatingcode_change/3to the user module.Update graceful shutdown child selection to recognize
DurableServerby membership rather than requiring the old singleton module list.Supporting information
This adds release-upgrade metadata only. It does not change discovery, restart eligibility, persistence, or shutdown status semantics.
Companion Sprites handoff change: https://github.com/superfly/sprites-api/pull/995