fix: remove doubled spacing between drag handle and checkbox - #974
Open
raswonders wants to merge 1 commit into
Open
fix: remove doubled spacing between drag handle and checkbox#974raswonders wants to merge 1 commit into
raswonders wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys
we've had problems with extra padding in columnManagementModal between drag & drop handle and checkbox. It seems to be caused by a wrong markup in ListManager. This PR solves that.
What
Remove extra spacing between the drag handle and checkbox in ListManager when drag-and-drop is enabled.
Why (AI)
DragDropSort already wraps each row in DataListItemRow and injects a drag-handle DataListControl. ListManager was wrapping the same content in a second DataListItemRow and a DataListCheck without otherControls, so PatternFly applied extra row padding between the handle and the checkbox.
How (AI)
Render drag-drop rows with PatternFly’s draggable DataList structure: checkbox inside DataListControl with otherControls={true}, and leave non-draggable rows on DataListItemRow. Tests cover both layouts.