fix: assemble Quick Action argv for clap operands and dash values - #257
Merged
Conversation
Create, append, prepend, tidy, apply-fragment, md, patch, and doc merge still put the file path before options. A path of --apply made clap treat it as the apply flag. Same -- terminator as #256. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Clap treats a following `--` or `-n` as end-of-options or another flag, so create/replace content starting with a dash failed. Bind user option values with equals form. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remaining Quick Action builders still put path operands before options. Clap then treats a later
--applyas a second apply flag when the path is--apply.This PR puts those paths after
--.serializePatchloomArgsstill inserts--applybefore--, so apply stays a flag.User option values that start with
-(Create content--, replace--new -n) also fail with space form. Builders now emit--flag=value.Change
withEndOfOptionson create, append, prepend, tidy, apply-fragment, markdown actions, patch apply/merge, and doc mergewithOptionfor user-supplied option values (--content=--,--new=-n, headings, predicates)["undo"](no mixed path and options)Validation
create --content=-- --apply -- filewrites--npm run check: 431 passed, 7 skipped, coverage and package greenNotes