test: resolve IFC WASM with hoisted dependencies - #865
Merged
Merged
Conversation
|
I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…). Please try again, rephrase, or reach out if it keeps failing. Error id: e178446b-e80d-40ca-a105-e5db86dff022 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The imported-mesh conversion tests fail when this repo is consumed as a submodule with dependencies hoisted to the parent: the hard-coded
editor/node_modules/web-ifcdirectory does not exist. Resolve the WASM directory from the installedweb-ifcmodule, matching the neighboring beam and opening tests.Validation: 8 imported-mesh conversion tests passed (6,077 assertions) against parent-hoisted dependencies; Biome and diff checks passed. Test setup only; converter behavior is unchanged.
Note
Low Risk
Test-only path resolution change; no production or converter logic is modified.
Overview
Updates imported-mesh conversion tests so
wasmPathis derived from the installedweb-ifcpackage viaimport.meta.resolve, instead of a fixed../../../node_modules/web-ifc/path.This lets the suite run when dependencies are hoisted to a parent repo (e.g. submodule consumption), consistent with the beam and opening IFC tests. Converter behavior is unchanged—only test fixture wiring.
Reviewed by Cursor Bugbot for commit 341fc6e. Bugbot is set up for automated code reviews on this repo. Configure here.