Skip to content

test: resolve IFC WASM with hoisted dependencies - #865

Merged
Aymericr merged 1 commit into
mainfrom
fix/ifc-test-wasm-resolution
Sep 14, 2026
Merged

Aymericr merged 1 commit into
mainfrom
fix/ifc-test-wasm-resolution

Conversation

@Aymericr

@Aymericr Aymericr commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

The imported-mesh conversion tests fail when this repo is consumed as a submodule with dependencies hoisted to the parent: the hard-coded editor/node_modules/web-ifc directory does not exist. Resolve the WASM directory from the installed web-ifc module, matching the neighboring beam and opening tests.

Validation: 8 imported-mesh conversion tests passed (6,077 assertions) against parent-hoisted dependencies; Biome and diff checks passed. Test setup only; converter behavior is unchanged.


Note

Low Risk
Test-only path resolution change; no production or converter logic is modified.

Overview
Updates imported-mesh conversion tests so wasmPath is derived from the installed web-ifc package via import.meta.resolve, instead of a fixed ../../../node_modules/web-ifc/ path.

This lets the suite run when dependencies are hoisted to a parent repo (e.g. submodule consumption), consistent with the beam and opening IFC tests. Converter behavior is unchanged—only test fixture wiring.

Reviewed by Cursor Bugbot for commit 341fc6e. Bugbot is set up for automated code reviews on this repo. Configure here.

@pascal

pascal Bot commented Sep 13, 2026

Copy link
Copy Markdown

I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…).

Please try again, rephrase, or reach out if it keeps failing.

Error id: e178446b-e80d-40ca-a105-e5db86dff022

@Aymericr
Aymericr merged commit 58a6b65 into main Sep 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant