fix(editor): clean up orphaned local asset:// files from IndexedDB by Zhao0335 · Pull Request #854 · pascalorg/editor

Zhao0335 · 2026-09-11T20:11:12Z

What does this PR do?

Fixes #733.

Deleting a local scan or guide node only routed http(s) URLs to onDeleteAsset. Local asset:// Files — including scans up to ~200 MB — stayed in IndexedDB forever after the referencing node was gone.

This PR schedules a delayed delete of the specific File when the last live node that pointed at it is removed:

Scene-panel delete of a scan/guide schedules the local File for removal after a 120s grace period (undo can still restore the node and load the blob).
Reference-panel delete and replace paths do the same for guide images.
deleteAsset in @pascal-app/core removes the IndexedDB entry and revokes any cached object URL.
A scene epoch is bumped on every applySceneGraphToEditor. Timers scheduled under a previous epoch refuse to delete, so switching projects cannot wipe a File another saved scene still uses.

It does not sweep "all unreferenced assets" on scene load. IndexedDB is origin-global and not scoped by scene.

How to test

Self-host the editor (bun dev), open a project, and upload a local guide image.
Delete the node from the Scene panel (or the reference panel).
Within ~2 minutes, Ctrl+Z the delete — the guide should still resolve.
Let the grace period elapse (or wait for the timer) — the IndexedDB entry for that asset should be gone (Application -> IndexedDB in DevTools).
Delete a local asset, then immediately open another project before the timer fires — the File must remain loadable when you reopen the first scene.
Open another scene that still has local assets — they must remain loadable (no cross-scene wipe).

Screenshots / screen recording

N/A — storage lifecycle only, no visual change.

Checklist

I've tested this locally with bun dev
My code follows the existing code style (run bun check to verify)
I've updated relevant documentation (if applicable)
This PR targets the main branch

Validation

packages/core: 1532 tests pass (bun run test)
packages/editor: local-asset-lifecycle.test.ts 6/6 pass
@pascal-app/core tsc --build clean
@pascal-app/editor check-types clean

Review follow-ups

Removed the fire-and-forget origin-wide orphan sweep so opening one scene cannot delete assets referenced by other graphs.
Added a scene epoch: delayed deletes scheduled under a previous applySceneGraphToEditor epoch are skipped, so a project switch during the grace window cannot delete a File another saved scene still references.

Note

Medium Risk
Changes how local blobs are deleted across origin-global IndexedDB; incorrect keep-sets or calling GC with a partial scene inventory could remove files still referenced by other scenes.

Overview
Adds safe, opt-in garbage collection for local asset:// blobs in IndexedDB (#733), replacing risky origin-wide or mount-time sweeps.

@pascal-app/core grows deleteAsset, listLocalAssetUrls, and sweepLocalAssetsExcept, plus deep collectors (collectNodeAssetUrls, collectSceneAssetUrls, collectGraphAssetUrlsFromParts) that walk nodes and materials for asset:// strings without deleting anything.

apps/editor/lib/local-asset-gc.ts implements runLocalAssetGc: it builds a keep-set from the live graph, localStorage draft scene, and every server scene (via /api/scenes), then sweeps only when that inventory is provably complete—returns null and skips if listing fails, a per-scene fetch fails, or the scene list hits the 500 cap. Live nodes are re-read immediately before sweeping.

Editor UI (reference panel, site panel) stops implying panel-level IndexedDB cleanup; comments state removal/replace flows defer to core scene mutations. A stale bootstrap comment is removed from scene-loader.tsx. Tests cover collectors, sweep behavior, and GC abort paths.

^{Reviewed by Cursor Bugbot for commit 276e5b0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Deleting a scan or guide node only routed http(s) URLs to onDeleteAsset. Local asset:// Files (up to 200 MB per scan) stayed in IndexedDB forever. - Add deleteAsset + sweepOrphanAssets to @pascal-app/core asset storage - Schedule delayed local deletes on node removal (undo-safe grace period) - Sweep unreferenced assets after applySceneGraphToEditor - Cover storage, lifecycle, undo-restore, and cancel paths with tests Fixes pascalorg#733

pascal · 2026-09-11T20:11:27Z

I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…).

Please try again, rephrase, or reach out if it keeps failing.

Error id: 92c31b27-f9c4-4ce1-a2fb-ce2e00b06d8f

cursor

Stale Bugbot comment from a previous run.

IndexedDB is origin-global and not scoped by project/scene. Sweeping every asset_data: entry missing from the just-loaded graph deleted local Files still referenced by other scenes, blank canvases, and previews. Keep only the undo-safe delayed delete when a node is removed. Fixes the orphaned-File leak from pascalorg#733 without a multi-scene wipe. Addresses review on pascalorg#854.

Zhao0335 · 2026-09-11T20:19:02Z

Addressed the Bugbot finding in d44b09d: removed the scene-load orphan sweep. IndexedDB is origin-global, so sweeping entries missing from the just-loaded graph could wipe assets still referenced by other scenes. Cleanup is now only the undo-safe delayed delete of a specific �sset:// File after its last live node is removed.

cursor

Stale Bugbot comment from a previous run.

The grace-period re-check only inspected the active useScene graph. Switching projects during the window could delete an origin-global IndexedDB File that another saved scene still referenced. Bump a scene epoch in applySceneGraphToEditor; timers scheduled under a previous epoch refuse to delete. Addresses review on pascalorg#854.

Zhao0335 · 2026-09-11T20:28:14Z

Addressed the latest Bugbot finding: delayed deletes now capture a scene epoch at schedule time. �pplySceneGraphToEditor bumps the epoch; timers from a previous epoch refuse to deleteAsset. Switching projects during the grace window no longer deletes origin-global IndexedDB Files that another saved scene still references. Covered by a new unit test.

Zhao0335 · 2026-09-11T20:43:13Z

This finding is already fixed on the current HEAD (cb97731), which is ahead of the reviewed 7ae66a2.

�pplySceneGraphToEditor bumps a scene epoch (�umpLocalAssetSceneEpoch).
scheduleLocalAssetDelete captures that epoch at schedule time; the timer returns without deleteAsset if the epoch changed (project/scene switch).
Covered by unit test: does not delete after a scene switch (another graph may still use the File).

No further code change needed for this comment.

Aymericr

Blocker: cleanup is attached to two UI handlers rather than the deletion lifecycle, so the bug still reproduces through supported delete paths.

For example, packages/editor/src/hooks/use-keyboard.ts deletes a selected guide/scan directly with useScene.getState().deleteNode(...), and the generic selection/delete surfaces in selection-routing.ts and group-actions.ts also bypass scheduleLocalAssetDelete. Deleting the same local reference with the Delete key therefore still leaves its asset:// File in IndexedDB.

Please move the scheduling to a single path that observes all committed node removals/replacements, or route every supported guide/scan deletion path through one shared helper. Add a regression test for keyboard deletion (and ideally delete-mode/generic selection deletion) so this cannot remain UI-entry-point dependent. The 120-second grace period, live-reference recheck, cache revocation, and scene-epoch guard are otherwise sensible.

Cleanup was attached to the Site panel and reference-panel handlers, so keyboard Delete (use-keyboard.ts), selection delete, MCP, and group actions still orphaned asset:// Files in IndexedDB (pascalorg#733). - Move grace-period scheduling into @pascal-app/core - Hook deleteNodesAction and applyNodeChanges delete/update paths - Cover keyboard-style deleteNode with a core regression test Fixes the remaining delete paths called out in review.

Zhao0335 · 2026-09-12T04:48:42Z

Addressed the deletion-lifecycle blocker in $(git rev-parse --short HEAD):

Local �sset:// scheduling now lives in @pascal-app/core and runs from deleteNodesAction (and �pplyNodeChanges deletes/url replacements), not the Site/reference panel handlers.
Covers keyboard Delete (use-keyboard.ts → deleteNode), selection delete, MCP delete_node, and group actions.
Regression test: packages/core/src/lib/local-asset-lifecycle-delete.test.ts — keyboard-style deleteNode schedules the File; a second live reference keeps it.

Grace period, live-reference recheck, cache revocation, and scene-epoch guard are unchanged.

cursor

Stale Bugbot comment from a previous run.

Aymericr

The central delete lifecycle now covers the missing keyboard/generic paths, but the current head still has three correctness blockers before cleanup is safe: (1) URL replacement schedules deletion without a fire-time scan of all live nodes, so undo or another node sharing the same asset:// URL can lose its File; (2) the reference-panel replacement schedules before updateNode commits, so a no-op/throw can delete the still-current asset; and (3) the scene epoch only advances in applySceneGraphToEditor, while unload/import/reset paths can replace the graph through setScene/clearScene and leave an old timer valid. Please make the timer predicate query the current graph for the URL at fire time, schedule replacements only after a committed change, and put epoch invalidation at the shared graph-replacement boundary. CI also needs the three Biome organize-import fixes shown by quality. Add regressions for shared-reference replacement, undo restoration, failed/no-op replacement, and a clear/set scene transition.

…Scene Address review on pascalorg#733 cleanup: - URL-replacement timers re-check the live graph at fire time (undo / shared asset:// handles) - Guide replace no longer schedules delete before updateNode commits - Epoch invalidation lives on unloadScene/setScene, not only applySceneGraphToEditor - organizeImports on the three CI-flagged files Regressions: shared-reference replace, undo restore, unreferenced replace, setScene epoch.

Zhao0335 · 2026-09-12T05:00:23Z

Addressed the three correctness blockers and Biome organizeImports on $head:

Replacement timers re-query the live graph for the URL at fire time (collectSceneAssetUrls(get().nodes)), so undo or a duplicate guide sharing the same �sset:// handle keeps its File.
Guide replace no longer schedules before updateNode; only the core updateNodes path schedules after the url change commits.
Epoch is bumped in unloadScene and setScene (shared graph-replacement boundary), not only �pplySceneGraphToEditor.

Regressions added for shared-reference replacement, undo restoration, unreferenced replacement, and setScene epoch. packages/core: 1545 tests pass.

Aymericr

The new fire-time live-graph checks fix the reported undo/shared-node cases, but there is still a cross-scene data-loss blocker. asset:// storage is origin-global, and scene/project duplication preserves those URLs. If scene A and an unopened saved scene B reference the same File, deleting the last reference in the currently loaded A schedules deleteAsset; staying in A for 120 seconds means the timer sees no current reference and deletes B’s File. The epoch only protects a scene switch during the grace window, not references in persisted scenes that were never loaded. This is the same ownership problem that made the original sweep unsafe.

Please do not physically delete origin-global Files based only on the active graph. The cleanup path needs a durable cross-scene reference index/refcount (updated atomically with scene persistence), per-scene asset ownership/copying, or a conservative explicit garbage-collection pass that can inspect every saved graph. Until one of those exists, this PR trades an orphan leak for silent corruption of another project. Add a regression with two persisted scenes sharing one asset URL; deleting from one must not break the other.

cursor

Stale Bugbot comment from a previous run.

Move bumpLocalAssetSceneEpoch import before material-library and put events/bus value export before its type export.

IndexedDB asset:// Files are origin-global and survive scene duplication, so deleting based on the loaded graph alone corrupts other saved scenes (pascalorg#733 review). - Remove automatic deleteAsset from deleteNodes/updateNodes timers - Core exposes sweepLocalAssetsExcept(keepUrls) for explicit GC - apps/editor GC unions current + localStorage + every server scene; skips the sweep when any source cannot be enumerated - Regression: two persisted scenes sharing one URL — delete from one must not break the other Fixes the cross-scene data-loss blocker.

Zhao0335 · 2026-09-12T19:19:48Z

Addressed the cross-scene data-loss blocker in 55e04ae.

No longer deletes origin-global Files from the active graph.

Removed automatic deleteAsset from deleteNodes / updateNodes timers.
Core now exposes explicit GC: sweepLocalAssetsExcept(keepUrls).
Standalone editor GC (apps/editor/lib/local-asset-gc.ts) builds the keep-set from current scene + localStorage scene + every /api/scenes graph. If any source cannot be enumerated, it skips the sweep rather than partial-deleting.
Regression test: two persisted scenes share one asset:// URL; sweeping with both keep-sets keeps the File.

Orphan leak may remain until a successful full enumeration runs — that is preferred over silent corruption of another project.

cursor

Stale Bugbot comment from a previous run.

- Treat a full /api/scenes page (limit=500, no cursor) as incomplete — never sweep when older scenes may still reference a File - Re-read useScene nodes immediately before sweepLocalAssetsExcept so uploads during the long per-scene fetch stay in the keep-set - Keep initialScene urls in the extra keep-set Addresses Bugbot findings on 55e04ae.

Zhao0335 · 2026-09-12T19:28:08Z

Fixed the two High findings on 0023ec0:

Truncated inventory — /api/scenes has no cursor; a full page (500) is treated as incomplete and GC skips instead of sweeping. Listing failure still skips.
In-flight uploads —
unLocalAssetGc takes a live-node getter and re-reads useScene immediately before sweepLocalAssetsExcept, and keeps initialScene urls in the extra keep-set.

Unit tests cover truncated list, failed list, and mid-GC live-graph growth.

cursor

Stale Bugbot comment from a previous run.

Mount-time GC races keepalive flush, other tabs, and uploads that have reached IndexedDB but not a node; sequential per-scene GETs also burn the autosave rate bucket. Keep runLocalAssetGc as an explicit host API only — never called from SceneLoader. Prefer leftover orphans over deleting live Files.

Zhao0335 · 2026-09-14T15:18:58Z

Addressed the mount-time GC findings on 3cc6f50:

Removed automatic runLocalAssetGc from SceneLoader mount.
runLocalAssetGc remains an explicit host API only (documented: no in-flight writes, complete inventory, spare rate budget).
Sequential per-scene GETs no longer run on page open, so they cannot starve autosave's rate bucket.

This leaves possible orphans in IndexedDB rather than deleting Files another tab, keepalive flush, or unpersisted upload still needs.

cursor

Stale Bugbot comment from a previous run.

Top-level url/src missed item.asset.*, captureSession.manifestUrl, and materials texture maps. Deep-walk nodes (depth-capped) and include graph.materials via collectGraphAssetUrlsFromParts.

Zhao0335 · 2026-09-14T15:28:34Z

Fixed keep-set completeness on 276e5b0:

collectNodeAssetUrls now deep-walks the node (depth 8, cycle-safe) so item.asset.src / thumbnail, captureSession.manifestUrl, and other nested asset:// strings are included.
New collectGraphAssetUrlsFromParts also walks graph.materials texture maps.
Unit tests cover nested item fields and materials maps.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 276e5b0. Configure here.}

cursor · 2026-09-14T15:35:50Z

+  const finalKeep = new Set<string>(keep)
+  for (const url of collectSceneAssetUrls(getLiveNodes() as never)) {
+    finalKeep.add(url)
+  }


Live GC keep-set omits materials

Medium Severity

runLocalAssetGc re-reads only live nodes via collectSceneAssetUrls before sweeping, and collectAllPersistedAssetUrls seeds the same way. Persisted graphs instead use collectGraphAssetUrlsFromParts, which includes materials. An unsaved asset:// texture on the live materials map never enters the keep-set, so sweepLocalAssetsExcept can delete it.

Additional Locations (1)

apps/editor/lib/local-asset-gc.ts#L41-L42

^{Reviewed by Cursor Bugbot for commit 276e5b0. Configure here.}

cursor Bot reviewed Sep 11, 2026

View reviewed changes

Comment thread packages/editor/src/lib/scene.ts Outdated

Zhao0335 added 2 commits September 12, 2026 04:18

chore: remove local PR_BODY.md from the branch

7ae66a2

cursor Bot reviewed Sep 11, 2026

View reviewed changes

Comment thread packages/editor/src/lib/local-asset-lifecycle.ts Outdated

Aymericr requested changes Sep 12, 2026

View reviewed changes

cursor Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread packages/core/src/store/actions/node-actions.ts Outdated

Comment thread packages/editor/src/components/ui/panels/reference-panel.tsx Outdated

Comment thread packages/editor/src/lib/scene.ts Outdated

Aymericr requested changes Sep 12, 2026

View reviewed changes

cursor Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread packages/core/src/store/actions/node-actions.ts Outdated

Zhao0335 added 3 commits September 13, 2026 02:07

chore: fix biome organizeImports for quality CI

d442411

Move bumpLocalAssetSceneEpoch import before material-library and put events/bus value export before its type export.

style: apply biome format to asset lifecycle files

ab8f3ca

cursor Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread apps/editor/lib/local-asset-gc.ts

Comment thread apps/editor/components/scene-loader.tsx Outdated

Zhao0335 added 2 commits September 13, 2026 03:33

style: organize imports in scene-loader

6ee6091

fix(app): type scene list JSON without never-narrowing

3bea691

cursor Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread apps/editor/lib/local-asset-gc.ts

Comment thread apps/editor/lib/local-asset-gc.ts

cursor Bot reviewed Sep 14, 2026

View reviewed changes

Comment thread packages/core/src/lib/local-asset-lifecycle.ts

fix(core): collect nested asset:// urls for GC keep-sets

276e5b0

Top-level url/src missed item.asset.*, captureSession.manifestUrl, and materials texture maps. Deep-walk nodes (depth-capped) and include graph.materials via collectGraphAssetUrlsFromParts.

cursor Bot reviewed Sep 14, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

Zhao0335 commented Sep 11, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

How to test

Screenshots / screen recording

Checklist

Validation

Review follow-ups

Uh oh!

pascal Bot commented Sep 11, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Zhao0335 commented Sep 11, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Zhao0335 commented Sep 11, 2026

Uh oh!

Zhao0335 commented Sep 11, 2026

Uh oh!

Aymericr left a comment

Choose a reason for hiding this comment

Uh oh!

Zhao0335 commented Sep 12, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Aymericr left a comment

Choose a reason for hiding this comment

Uh oh!

Zhao0335 commented Sep 12, 2026

Uh oh!

Aymericr left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Zhao0335 commented Sep 12, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Zhao0335 commented Sep 12, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Zhao0335 commented Sep 14, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Zhao0335 commented Sep 14, 2026

Uh oh!

Zhao0335 commented Sep 11, 2026 •

edited by cursor Bot

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading