Conversation
Signed-off-by: Justin Gong <jugong@jugong-mlt.client.nvidia.com>
xovishnukosuri
pushed a commit
to xovishnukosuri/p4runtime-shell
that referenced
this pull request
Mar 14, 2026
P4Runtime v1.4.0 added MeterSpec.Type (TWO_RATE_THREE_COLOR, SINGLE_RATE_THREE_COLOR, SINGLE_RATE_TWO_COLOR) with specific field constraints for each type. The shell was not reading or enforcing these constraints. This change: - Reads spec.type from the meter's P4Info in _MeterEntryBase - Adds _MeterConfig.validate() which raises UserError if the config violates the constraints imposed by the meter's spec.type - Calls validate() from _MeterEntryBase._validate_msg() and from TableEntry._validate_msg() for tables with a direct meter - Adds two new meter fixtures (MeterB, MeterC) to the test P4Info and three new unit tests covering all three type validations Closes p4lang#149 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
fruffy
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support P4runtime v1.4.1 Meter's spec.type configuration