fix(parser): report TS2369 for parameter properties outside constructors - #26056
Open
MuntasirSZN wants to merge 1 commit into
Open
fix(parser): report TS2369 for parameter properties outside constructors#26056MuntasirSZN wants to merge 1 commit into
MuntasirSZN wants to merge 1 commit into
Conversation
TypeScript reports accessibility/`readonly`/`override` modifiers on
parameters of non-constructor functions as TS2369 ("A parameter property
is only allowed in a constructor implementation."), not TS1090. TS1090
remains for other modifiers (`static`, `export`, `async`, `declare`,
...).
Signed-off-by: MuntasirSZN <muntasir.joypurhat@gmail.com>
camc314
reviewed
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript reports accessibility/
readonly/overridemodifiers onparameters of non-constructor functions as TS2369 ("A parameter property
is only allowed in a constructor implementation."), not TS1090. TS1090
remains for other modifiers (
static,export,async,declare,...).
Signed-off-by: MuntasirSZN muntasir.joypurhat@gmail.com