OCPBUGS-111965: Remove unnecessary reqserving management cluster override - #84262
OCPBUGS-111965: Remove unnecessary reqserving management cluster override#84262PoornimaSingour wants to merge 2 commits into
Conversation
Remove OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE from reqserving-e2e-aws job across all branches. This override was added without technical justification and pins management clusters to outdated versions. Changes: - Main: Remove override to release:latest-421 (now uses default 5.1) - Release 4.21-5.2: Remove overrides (now use branch default versions) The override was cargo-culted from initial PR openshift#70989 and propagated through config-brancher. No other AWS e2e jobs use this pattern (except kubevirt jobs which have documented ODF dependency). Guest clusters are unaffected - they continue using release:latest. Fixes: OCPBUGS-111965
|
@PoornimaSingour: This pull request references Jira Issue OCPBUGS-111965, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (7)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe ChangesReqserving release selection
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized configuration change removes outdated management-cluster version pinning while leaving guest-cluster behavior unchanged; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. Full details: Stable And Deterministic Test NamesExplanation PASS. The PR delta is limited to 14 deletions in seven CI YAML files. It removes Full details: Test Structure And QualityExplanation PASS: The pull request changes only seven YAML CI configuration files. The exact diff removes two dependency lines from the Full details: Microshift Test CompatibilityExplanation The check is not applicable. The pull-request commit changes only seven HyperShift CI YAML files and removes two dependency lines from the existing Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS. The PR adds no Ginkgo e2e tests. The PR-side diff contains only seven YAML files, with 14 deletions and no additions. The changes remove dependencies from existing CI job definitions; they do not add or modify It(), Describe(), Context(), or When() test bodies. Therefore, the SNO compatibility check is not applicable. Full details: Topology-Aware Scheduling CompatibilityExplanation PASS — The pull request changes only seven Full details: Ote Binary Stdout ContractExplanation PASS: The PR changes only seven Hypershift YAML configuration files. The diff removes Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS — The PR changes only seven CI YAML files. The exact PR diff removes Full details: No-Weak-CryptoExplanation PASS: The pull-request diff changes only seven CI YAML files. It contains 14 deletions and no additions. The deletions remove release-image override settings from Full details: Container-PrivilegesExplanation PASS. The contributor patch contains only 14 deleted lines across seven Hypershift CI YAML files. It removes Full details: No-Sensitive-Data-In-LogsExplanation PASS — The PR-local commit changes only six CI YAML files and removes 12 lines containing the release-image override. The affected jobs retain only existing cluster and workflow configuration. No logging calls, log commands, secrets, tokens, credentials, PII, hostnames, or customer data are added by the change. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@PoornimaSingour: This pull request references Jira Issue OCPBUGS-111965, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
/pj-rehearse pull-ci-openshift-hypershift-release-5.1-reqserving-e2e-aws pull-ci-openshift-hypershift-release-5.2-reqserving-e2e-aws pull-ci-openshift-hypershift-release-4.23-reqserving-e2e-aws pull-ci-openshift-hypershift-release-4.22-reqserving-e2e-aws |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
/pj-rehearse pull-ci-openshift-hypershift-main-reqserving-e2e-aws |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/pj-rehearse pull-ci-openshift-hypershift-main-reqserving-e2e-aws |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Previously, OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE was hardcoding the management cluster to an older version across all branches: So branches like main (which is 5.1) and release-5.0 were testing with a 4.21 management cluster — two major versions behind. **After fix: 📊 Rehearsal Failure Analysis: **
Every job successfully:
Failures are ONLY in:
|
|
/rebase |
…ve-reqserving-override
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-hypershift-main-reqserving-e2e-aws |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PoornimaSingour, vismishr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@PoornimaSingour: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse pull-ci-openshift-hypershift-release-5.1-reqserving-e2e-aws pull-ci-openshift-hypershift-release-4.23-reqserving-e2e-aws pull-ci-openshift-hypershift-release-4.22-reqserving-e2e-aws pull-ci-openshift-hypershift-main-reqserving-e2e-aws |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@PoornimaSingour: job(s): pull-ci-openshift-hypershift-release-4.23-reqserving-e2e-aws, either don't exist or were not found to be affected, and cannot be rehearsed |
Description:
Summary
Remove unnecessary
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDEfrom thereqserving-e2e-awsjob across all branches (main, 4.21-5.2).Problem
The override was pinning management clusters to outdated versions (4.20/4.21) without technical justification:
Root Cause Analysis
Traced through git history:
release:latest-420in CNTRLPLANE-1644: test(hypershift): add request-serving e2e test workflow #70989 (no justification)421during version sync (hypershift: sync 4.22 presubs #72614)Solution
Remove the override to allow management clusters to use appropriate default versions:
Guest clusters are unaffected - they continue using
release:latest.Testing
make updatepassedci-operator-checkconfigpassedci-operator-prowgencompletedSummary by CodeRabbit
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDEfrom thereqserving-e2e-awsCI job for main and release branches 4.21–5.2.release:latest.