Conversation
CI installs MicroShift by building RPMs from source and installing them via a --repofrompath local repository. Once microshift RPMs became available in the rhocp-4.21 product repository with a release version (e.g. 4.21.29-...) that sorts higher than the locally built nightly version, dnf silently resolved 'microshift' from the product repository instead of the local one. As a result, CI jobs tested the released RPM (pinning an outdated ovn-kubernetes image affected by OCPBUGS-105440) instead of the RPMs built from the checked-out source, causing all release-4.21 conformance jobs to permafail with 'failed to get ofport of -ex' even after the fix merged. Set the highest repository priority on the local repository so dnf always prefers the locally built RPMs regardless of version ordering. Assisted-By: Claude Fable 5
openshift-ci-robot
added
the
jira/valid-reference
|
@mkowalski: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. WalkthroughThe VM configuration now assigns priority ChangesLocal repository priority
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change is limited to configure-vm.sh and makes repository selection prefer locally built RPMs; no actionable correctness or deployment risk remains, so it is merge-ready after normal checks. Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
Full details: Stable And Deterministic Test NamesExplanation PASS: The pull request changes only Full details: Test Structure And QualityExplanation PASS: The pull request changes only Full details: Microshift Test CompatibilityExplanation PASS: The pull request changes only scripts/devenv-builder/configure-vm.sh. The patch adds a DNF repository priority setting and adds no Ginkgo e2e tests or other test declarations. The MicroShift test compatibility check is therefore not applicable. Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request changes only Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request changes only Full details: Ote Binary Stdout ContractExplanation PASS: The pull request changes only Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation The check is not applicable. The PR changes only Full details: No-Weak-CryptoExplanation PASS. The exact diff changes only comments and adds Full details: Container-PrivilegesExplanation The pull request changes only Full details: No-Sensitive-Data-In-LogsExplanation PASS: The pull request changes only the DNF repository priority and adds explanatory comments. The new argument is the non-sensitive value
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkowalski The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
coderabbitai
Bot
added
the
ready-for-human-review
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
This fix is correct and addresses the root cause of the 4.21 nightly permafail (and a latent issue on all branches). The problem: The The fix: Evidence: Confirmed by examining the Tracked in USHIFT-7489. AI-generated. Review for accuracy. |
|
@mkowalski: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Replaced by #7262 |
|
@pacevedom: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
What
Set
priority=1on themicroshift-localrepository used byconfigure-vm.shso dnf always installs the locally built RPMs instead of anymicroshiftRPMs published in enabled product repositories.Same change as #7257 (release-4.21), applied to this branch since the script is identical here and equally exposed.
Why
On release-4.21, all conformance CI jobs permafailed because dnf resolved
microshiftfromrhocp-4.21-for-rhel-9-x86_64-rpms(released NEVRA4.21.29-...sorts higher than the locally built nightly version) instead of the source-built RPMs in the--repofrompathlocal repo. The released RPM pins an outdated ovn-kubernetes image (missing the OCPBUGS-105440 fix), so CI kept hitting an already-fixed bug. See #7257 for the full investigation.The same silent version-ordering hazard exists on every branch once a matching product repo publishes a higher-versioned microshift RPM. With repository priority 1 on the local repo, dnf prefers packages from it regardless of version ordering, so CI tests what it built.
How was this tested
bash -nandshellcheckon the modified script (no new findings). Behavioral verification comes from CI on this PR; not verified locally.This PR description was generated using AI. Please verify before acting on it.
Assisted-By: Claude Fable 5
Summary by CodeRabbit