Add upward OF-path search and missing-binary detection to the GUI - #650
Merged
Merged
Conversation
danoli3
force-pushed
the
of-path-detection-fix
branch
2 times, most recently
from
September 14, 2026 07:40
42efaba to
5eef30f
Compare
The Electron frontend's own OF-path guess was a single fixed-depth computation (__dirname/../../../) with no validation - only correct if frontend/ sits at exactly <OF_ROOT>/apps/projectGenerator/frontend. Its only real fallback (asking cmdLine via --getofpath, which does a proper upward search) silently did nothing when the cmdLine binary wasn't built/copied into frontend/app/ yet, since execFile/spawn just threw a generic ENOENT with no clear message. Add isGoodOFPath()/findOFPathUpwards() in the GUI itself (mirroring the equivalent functions in commandLine/src/main.cpp) so path detection works standalone, without needing the binary. Also give every cmdLine-backed IPC call a clear "commandLine binary not found, build it first" error instead of a bare ENOENT. Also fixes two bugs found while testing this: the "running on macOS for the first time" Gatekeeper warning had a hardcoded 400px height regardless of content, and its trigger check matched any path starting with "/private" (which includes ordinary /tmp, /var, /etc paths on macOS, since those are symlinks) instead of the actual AppTranslocation path Gatekeeper uses.
danoli3
force-pushed
the
of-path-detection-fix
branch
from
September 14, 2026 08:16
5eef30f to
198cc68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Electron frontend’s fragile OF-path detection by adding standalone upward path searching, plus clear errors when the cmdLine binary is missing.
Also fixes and improves the macOS Gatekeeper warning, with testing confirming correct OF detection, error handling, and UI rendering.