Skip to content

Add language selection with translations for 9 languages - #649

Merged
danoli3 merged 1 commit into
openframeworks:masterfrom
danoli3:i18n-language-selection
Sep 14, 2026
Merged

danoli3 merged 1 commit into
openframeworks:masterfrom
danoli3:i18n-language-selection

Conversation

@danoli3

@danoli3 danoli3 commented Sep 11, 2026

Copy link
Copy Markdown
Member

Summary

  • New Settings > Language dropdown; auto-detects from the OS locale on first run (app.getLocale()), falls back to English, and persists the user's choice.
  • Covers all static UI text plus the dynamic success/error/status messages the GUI builds itself (addon clone, generate/update, oF Menu, Emscripten build).
  • Locale bundles live in frontend/locales/*.json: English, Spanish, French, German, Portuguese, Japanese, Korean, Chinese (Simplified), Russian.

@danoli3
danoli3 force-pushed the i18n-language-selection branch 2 times, most recently from 28af5e3 to c7d0465 Compare September 14, 2026 07:38
New Settings > Language dropdown; auto-detects from the OS locale on
first run, falls back to English. Covers all static UI text plus the
dynamic success/error/status messages the GUI builds (addon clone,
generate/update, oF Menu, Emscripten build). Locale bundles live in
frontend/locales/*.json (en, es, fr, de, pt, ja, ko, zh-CN, ru).

Also fixes a real bug found while wiring this up: displayModal() was
deciding button visibility by string-matching the literal English word
"Success!" in the message - translating that string would have
silently broken the Open in IDE / Build & Preview buttons for every
non-English user. Replaced with the existing <!--modal-context--> HTML
comment marker system (new project-success marker) so button
visibility no longer depends on message language.
@danoli3
danoli3 force-pushed the i18n-language-selection branch from c7d0465 to cb833e4 Compare September 14, 2026 09:36
@danoli3
danoli3 merged commit 4731714 into openframeworks:master Sep 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant