Add language selection with translations for 9 languages - #649
Merged
Merged
Conversation
danoli3
force-pushed
the
i18n-language-selection
branch
2 times, most recently
from
September 14, 2026 07:38
28af5e3 to
c7d0465
Compare
New Settings > Language dropdown; auto-detects from the OS locale on first run, falls back to English. Covers all static UI text plus the dynamic success/error/status messages the GUI builds (addon clone, generate/update, oF Menu, Emscripten build). Locale bundles live in frontend/locales/*.json (en, es, fr, de, pt, ja, ko, zh-CN, ru). Also fixes a real bug found while wiring this up: displayModal() was deciding button visibility by string-matching the literal English word "Success!" in the message - translating that string would have silently broken the Open in IDE / Build & Preview buttons for every non-English user. Replaced with the existing <!--modal-context--> HTML comment marker system (new project-success marker) so button visibility no longer depends on message language.
danoli3
force-pushed
the
i18n-language-selection
branch
from
September 14, 2026 09:36
c7d0465 to
cb833e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.getLocale()), falls back to English, and persists the user's choice.frontend/locales/*.json: English, Spanish, French, German, Portuguese, Japanese, Korean, Chinese (Simplified), Russian.