feat: replace enterprise support enrollment imports with filter call - #39083
Draft
brobro10000 wants to merge 1 commit into
Draft
feat: replace enterprise support enrollment imports with filter call#39083brobro10000 wants to merge 1 commit into
brobro10000 wants to merge 1 commit into
Conversation
This was referenced Sep 8, 2026
ENT-11574 Removes the direct openedx.features.enterprise_support imports and the _enterprise_course_enrollments_by_course_id helper from EnrollmentSupportListView, replacing them with a call to the new SupportEnrollmentDataRequested openedx-filter. Per pwnage101's review feedback on the sibling SupportContactContextRequested filter, run_filter now returns a tuple of all its inputs (enrollment_data, user) rather than a bare dict, matching the convention used by every other filter. No settings changes here: OPEN_EDX_FILTERS_CONFIG registration for the pipeline step lives in edx-enterprise's own plugin_settings() (enterprise/settings/common.py), per the ENT-11830 ownership handoff. The test now mocks the filter call at the view layer; the enterprise-specific pipeline step behavior is covered by edx-enterprise's own test suite.
brobro10000
force-pushed
the
brobro10000/ENT-11574-enrollment
branch
from
September 8, 2026 16:46
6cf55b9 to
abd843c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENT-11574
Companion PR to the already-open support-contact-tag PR set (openedx-filters#390,
edx-enterprise#2688, openedx-platform#39076, edx-platform#455) — this one covers the
other half of ENT-11574's acceptance criteria: enterprise enrollment data for the support
enrollment view.
Removes the direct
openedx.features.enterprise_supportimports and the_enterprise_course_enrollments_by_course_idhelper fromEnrollmentSupportListView,replacing them with a call to the new
SupportEnrollmentDataRequestedopenedx-filter. Nosettings changes in this PR:
OPEN_EDX_FILTERS_CONFIGregistration for the pipeline steplives entirely in edx-enterprise's own
plugin_settings()(enterprise/settings/common.py),per the
ENT-11830ownership handoff — already merged in this repo (#38634) well before thisbranch existed.
lms/djangoapps/support/views/contact_us.pyis untouched — this PR is scoped to theenrollment filter only.
Related PRs
openedx-platform#39076, edx-platform#455 (support-contact-tag)
Merge order (per the enterprise plugin ticket runbook)
This PR merges LAST, only after:
confirmed working.
CI note
CI here is expected to be red on Django-app-boot-dependent jobs until openedx-filters and
edx-enterprise are released and this repo's
requirements/edx/base.txtpin is bumped — CIinstalls the published PyPI versions, which don't yet contain
SupportEnrollmentDataRequested/the new pipeline step. Same situation as the siblingcontact-tag PR (openedx-platform#39076) and pwnage101's own
ENT-11573(#38109) historically.Not a bug in this diff — it self-resolves per the runbook's release ordering.
Testing
New:
SupportEnrollmentDataRequested.run_filteris mocked at the call site inlms/djangoapps/support/tests/test_views.py— the pipeline-step behavior itself is coveredby edx-enterprise's own test suite.
Local devstack integration testing (with the openedx-filters, edx-enterprise, and edx-platform
branches checked out together) is required before any of these PRs merge.