fix(models): retry pre-request WebSocket handshake failures - #4780
Open
CoralGarden52 wants to merge 1 commit into
Open
fix(models): retry pre-request WebSocket handshake failures#4780CoralGarden52 wants to merge 1 commit into
CoralGarden52 wants to merge 1 commit into
Conversation
CoralGarden52
marked this pull request as ready for review
August 30, 2026 11:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAIResponsesWSModelcould fail immediately when the peer closed during the WebSocket HTTP upgrade. With the supportedwebsockets>=15client, a close before a valid HTTP 101 response is reported aswebsockets.exceptions.InvalidMessage. That exception was raised before_ensure_websocket_connectionreturned, so the existing pre-event retry path never handled it.This change:
InvalidMessagecase;Test plan
response.createframe, andresponse_id=resp_local_probe.make tests: 9292 passed, 29 skipped; serial tests: 77 passed, 4 skipped..agents/skills/code-change-verification/scripts/run.sh: passed (format, lint, typecheck, and tests).InvalidMessage,websocket handshake,pre-event websocket, andwebsocket retry; no duplicate open PR was found.Issue number
No existing issue found; the failure was reproduced locally against the real
websocketshandshake path.Checks
.agents/skills/code-change-verification/scripts/run.shThis PR is intentionally opened as a draft pending maintainer review.