Conversation
xrmx
reviewed
Sep 11, 2026
Pull request dashboard statusWaiting on the author · refreshed 2026-09-14 17:15 UTC Respond to 2 review items (e.g. link a commit, explain why not, ask a follow-up): Status above doesn't look right?
|
jaydeluca
commented
Sep 11, 2026
herin049
reviewed
Sep 12, 2026
| self.assertEqual(resource.attributes["telemetry.sdk.language"], "python") | ||
| self.assertIn(HOST_NAME, resource.attributes) | ||
|
|
||
| @patch("platform.system", lambda: "Linux") |
Contributor
There was a problem hiding this comment.
Can we add some integration tests that run the full detector and perform basic validation on the attributes? (at least for Linux and Windows which run in CI)
| opentelemetry.sdk.resources package | ||
| ========================================== | ||
|
|
||
| Host resource detection |
Contributor
There was a problem hiding this comment.
Can we link to: https://opentelemetry.io/docs/specs/semconv/resource/host/
emdneto
added
the
Approve Public API check
emdneto
approved these changes
Sep 14, 2026
lzchen
approved these changes
Sep 14, 2026
herin049
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the existing host resource detector to include
host.idas defined in https://opentelemetry.io/docs/specs/semconv/resource/host/Fixes #5652
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests for some of the flows. Tested on my mac with a local small app:
Does This PR Require a Contrib Repo Change?
Checklist: